Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject duplicate versions by default #31

Open
dexman545 opened this issue Nov 3, 2022 · 2 comments
Open

Reject duplicate versions by default #31

dexman545 opened this issue Nov 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@dexman545
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Previously, when using automated uploads Modrinth would reject identical versions. This is no longer the case, causing automated uploads relying on this feature to upload multiple of the same version.

Describe the solution you'd like
Fail or skip the upload task when the version is already present on Modrinth

Describe alternatives you've considered
This is fairly easy to work around with Outlet, as it already has a way to query Modrinth for an existing version for a given set of loaders/mc versions, making skipping the task an onlyIf call.

Additional context
Add any other context or screenshots about the feature request here.

@dexman545 dexman545 added the enhancement New feature or request label Nov 3, 2022
@Deftu
Copy link

Deftu commented Nov 3, 2022

Identical version numbers are intended. I guess an API input disabling them could be implemented? But aside from that the current functionality is how things should stay imo.

@Siphalor
Copy link
Contributor

Siphalor commented Dec 25, 2022

I'd suggest rejecting by default, but allowing behavior through a config option, either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants