Miscellaneous additions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One big PR is fine. It's easy enough to cherry-pick the commits if necessary. |
yallop
previously requested changes
Aug 3, 2023
dvlasits
reviewed
Aug 3, 2023
dvlasits
reviewed
Aug 3, 2023
dvlasits
reviewed
Aug 3, 2023
Co-authored-by: Daniel Vlasits <dvlasits@gmail.com>
dvlasits
reviewed
Aug 3, 2023
Co-authored-by: Daniel Vlasits <dvlasits@gmail.com>
dvlasits
reviewed
Aug 3, 2023
pxeger
commented
Aug 4, 2023
numbers form many monoids - under addition, multiplication, etc. so it is a bit weird to choose addition arbitrarily as the "canonical" Monoid instance for them
yallop
reviewed
Aug 9, 2023
| let fmap m (a, b) = (a, m b) | ||
| end | ||
|
|
||
| type ('a, 'b) const = Const of 'a |
There was a problem hiding this comment.
I wonder whether this can be defined simply as
Suggested change
| type ('a, 'b) const = Const of 'a | |
| type ('a, 'b) const = 'a |
If it does need to be a proper (generative) type, it'd be better as a record, so that it's easy to destruct as well as construct:
type ('a, 'b) const = { const: 'a }There was a problem hiding this comment.
Daniel wants me to merge this so I'm going to make this an issue and deal with it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a bunch of small, fairly logically separate, changes like this, is it better to make one big PR like this, or split into many smaller PRs? I thought I'd choose this option so it would be easier to merge, but is that a bad idea because it makes it harder to "pick and choose" changes?