Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new beta non-rfc fields in dns managed zone #348

Conversation

modular-magician
Copy link
Owner

Fixes: hashicorp/terraform-provider-google#5062

I cribbed the object_to_bool and bool_to_object code from: GoogleCloudPlatform/magic-modules#3007 as this will likely make it in before that.

Release Note Template for Downstream PRs (will be copied)

dns: `google_dns_managed_zone` added support for Non-RFC1918 fields for reverse lookup and fowarding paths.

Derived from GoogleCloudPlatform/magic-modules#3026

* Add support for new beta non-rfc fields in dns managed zone

* Test updating forwarding path

* Forgot to remove a param

* Typo

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 5163231 into master Jan 25, 2020
slevenick pushed a commit that referenced this pull request Feb 20, 2020
…348)

* Add support for new beta non-rfc fields in dns managed zone

* Test updating forwarding path

* Forgot to remove a param

* Typo

Signed-off-by: Modular Magician <magic-modules@google.com>
slevenick pushed a commit that referenced this pull request Apr 13, 2020
…348)

* Add support for new beta non-rfc fields in dns managed zone

* Test updating forwarding path

* Forgot to remove a param

* Typo

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS Non-RFC1918 support
1 participant