[stdlib] Refactor format_int.mojo
#3348
Open
+157
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I forgot about something. |
…ponding TODO's. Signed-off-by: Max Brylski <helehex@gmail.com>
helehex
force-pushed
the
stdlib/refactor-format-int
branch
from
458e6e6
to
4d5ca79
Compare
|
Ok, I added those tests back in. |
ConnorGray
reviewed
Aug 5, 2024
| @@ -591,9 +591,7 @@ struct _ObjectImpl( | |||
| ) | |||
| return | |||
| if self.is_func(): | |||
| writer.write( | |||
| "Function at address " + hex(int(self.get_as_func().value)) | |||
| ) | |||
There was a problem hiding this comment.
Question Is there a way we might be able to keep the hex(..) formatting here?
There was a problem hiding this comment.
Followup Never mind, I see you've changed the formatting of UnsafePointer to use hex by default as well.
That seems reasonable to me, though it would be great to call that out in the description as well :)
|
!sync |
modularbot
added
the
imported-internally
|
FYI this is still hitting some compiler bugs internally in the elaborator, so added the "blocked" label on this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
format_int.mojoto use Formatter, and take care of corresponding TODO's.