[stdlib] Use ownership ops in Uninit to remove pointer indirection.
#3453
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed`, and remove unnecessary pointer indirection within the type Signed-off-by: Max Brylski <helehex@gmail.com>
gabrieldemarmiesse
suggested changes
Sep 7, 2024
| @@ -89,7 +89,7 @@ def test_maybe_uninitialized_move_from_pointer(): | |||
| _ = a^ | |||
|
|
|||
| # a is uninitialized now. Thankfully, we're working with trivial types | |||
| assert_equal(b.assume_initialized().move_count, 1) | |||
| assert_equal(b.assume_initialized().move_count, 2) | |||
There was a problem hiding this comment.
This is quite strange indeed. Can you add a unit test with a non-movable type and see if it works correctly?
There was a problem hiding this comment.
Once I figure out stdlib dev with magic, i'll add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ownership ops provide a more clear implementation than
pop.array, and allows the pointer indirection to be removed.This makes the inner field of
UnsafeMaybeUninitializedjust aElementTypeinstead of apop.array<...>Because we get an error when marking subobjects as destroyed, i used a capturing function within the types destructor to make sure the underlying values destructor isn't called.
I had to bump up the move counter check in one of the tests, because of how the implementation changed, but i'm pretty sure the actual move gets optimized away, even if the move counter doesn't.