[stdlib] Fix chr impl taking funcs to string_slice and separating #3506
+59
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
martinvuyk
commented
Sep 19, 2024
| return int((sizes < c).cast[DType.uint8]().reduce_add()) | ||
|
|
||
|
|
||
| fn _shift_unicode_to_utf8(ptr: UnsafePointer[UInt8], c: Int, num_bytes: Int): |
There was a problem hiding this comment.
I'm not sure of this argument ordering but I don't know if we have any such sort of convention yet
There was a problem hiding this comment.
There's no convention yet, I could make a case either way: weak preference towards putting num_bytes as the second argument.
JoeLoser
approved these changes
Sep 19, 2024
| return int((sizes < c).cast[DType.uint8]().reduce_add()) | ||
|
|
||
|
|
||
| fn _shift_unicode_to_utf8(ptr: UnsafePointer[UInt8], c: Int, num_bytes: Int): |
There was a problem hiding this comment.
There's no convention yet, I could make a case either way: weak preference towards putting num_bytes as the second argument.
|
!sync |
modularbot
added
the
imported-internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix chr implementation taking funcs to string_slice and separating their respective functionalities.
This code will be used elsewhere e.g., PR #3496