feat: support interface data prefetch #2543

nyqykk · 2024-05-27T09:49:55Z

Description

Support remote module send their interface request along with the module static resource in advance, rather than render to call request.
This will be useful when remote module load for a long time, their request will be parallel with the module itself.
And it also useful for secondary screen, the module can show directly with it's data

Related Issue

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have added tests to cover my changes.
All new and existing tests passed.
I have updated the documentation.

changeset-bot · 2024-05-27T09:49:59Z

🦋 Changeset detected

Latest commit: 62b029d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages

Name	Type
@module-federation/data-prefetch	Patch
@module-federation/enhanced	Patch
@module-federation/modern-js	Patch
@module-federation/nextjs-mf	Patch
@module-federation/node	Patch
3008-runtime-remote	Patch
host	Patch
host-v5	Patch
host-vue3	Patch
remote1	Patch
remote2	Patch
remote3	Patch
remote4	Patch
@module-federation/modernjs	Patch
modernjs-ssr-dynamic-nested-remote	Patch
modernjs-ssr-dynamic-remote-new-version	Patch
modernjs-ssr-dynamic-remote	Patch
modernjs-ssr-host	Patch
modernjs-ssr-nested-remote	Patch
modernjs-ssr-remote-new-version	Patch
modernjs-ssr-remote	Patch
@module-federation/runtime	Patch
@module-federation/rspack	Patch
@module-federation/webpack-bundler-runtime	Patch
@module-federation/sdk	Patch
@module-federation/runtime-tools	Patch
@module-federation/managers	Patch
@module-federation/manifest	Patch
@module-federation/dts-plugin	Patch
@module-federation/third-party-dts-extractor	Patch
@module-federation/devtools	Patch
@module-federation/bridge-react	Patch
@module-federation/bridge-vue3	Patch
@module-federation/bridge-shared	Patch
@module-federation/bridge-react-webpack-plugin	Patch
@module-federation/retry-plugin	Patch
@module-federation/esbuild	Patch
@module-federation/utilities	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2024-05-27T09:50:11Z

✅ Deploy Preview for module-federation-docs ready!

Name	Link
🔨 Latest commit	`62b029d`
🔍 Latest deploy log	https://app.netlify.com/sites/module-federation-docs/deploys/66ea8fc29b38c800087c7fbc
😎 Deploy Preview	https://deploy-preview-2543--module-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/data-prefetch/src/prefetch.ts

+    if (!this.recordOutdate[id]) {
+      this.recordOutdate[id] = {};
+    }
+    this.recordOutdate[id][functionId] = isOutdate;


…xtra file

zhoushaw · 2024-07-04T07:06:19Z

mr Description information needs to let users know the corresponding information

apps/manifest-demo/3010-rspack-provider/src/App.tsx

packages/data-prefetch/README.md

packages/data-prefetch/src/prefetch.ts

packages/data-prefetch/package.json

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

This reverts commit 7a8d0fe.

squadronai

Incremental Review

Comments posted: 0

Configuration

Squadron Mode: essential

Commits Reviewed

d7551fe1a4b5520d96ee3a3522ad14df7d354370...575c4548125f054cb448b706ed0390222c7aadf5

Files Reviewed

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

.changeset/light-items-battle.md
.github/workflows/e2e-manifest.yml
apps/manifest-demo/3009-webpack-provider/tsconfig.app.json
apps/manifest-demo/3009-webpack-provider/tsconfig.json
apps/manifest-demo/3010-rspack-provider/package.json
apps/manifest-demo/3010-rspack-provider/rspack.config.js
apps/manifest-demo/3010-rspack-provider/src/App.tsx
apps/manifest-demo/webpack-host/src/App.tsx
apps/manifest-demo/webpack-host/webpack.config.js
apps/modernjs/cypress/e2e/app.cy.ts
apps/modernjs/modern.config.ts
apps/modernjs/src/components/react-component.prefetch.ts
apps/modernjs/src/components/react-component.tsx
apps/modernjs/src/routes/page.tsx
apps/website-new/docs/en/guide/_meta.json
apps/website-new/docs/en/guide/performance/_meta.json
apps/website-new/docs/en/guide/performance/prefetch.mdx
apps/website-new/docs/public/guide/performance/data-prefetch/common.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/log.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/prefetch.jpg
apps/website-new/docs/zh/guide/_meta.json
apps/website-new/docs/zh/guide/performance/_meta.json
apps/website-new/docs/zh/guide/performance/prefetch.mdx
package.json
packages/data-prefetch/CHANGELOG.md
packages/data-prefetch/README.md
packages/data-prefetch/tests/babel.spec.ts
packages/data-prefetch/tests/prefetch.spec.ts
packages/data-prefetch/tests/react.spec.ts
packages/data-prefetch/jest.config.js
packages/data-prefetch/package.json
packages/data-prefetch/project.json
packages/data-prefetch/src/cli/babel.ts
packages/data-prefetch/src/cli/index.ts
packages/data-prefetch/src/common/constant.ts
packages/data-prefetch/src/common/index.ts
packages/data-prefetch/src/common/node-utils.ts
packages/data-prefetch/src/common/runtime-utils.ts
packages/data-prefetch/src/index.ts
packages/data-prefetch/src/logger/index.ts
packages/data-prefetch/src/plugin.ts
packages/data-prefetch/src/prefetch.ts
packages/data-prefetch/src/react/hooks.ts
packages/data-prefetch/src/react/index.ts
packages/data-prefetch/src/react/utils.ts
packages/data-prefetch/src/shared/index.ts
packages/data-prefetch/src/universal/index.ts
packages/data-prefetch/tsconfig.json
packages/data-prefetch/tsup.config.ts
packages/enhanced/package.json
packages/manifest/tsconfig.json
packages/webpack-bundler-runtime/src/initContainerEntry.ts
packages/webpack-bundler-runtime/src/types.ts
pnpm-lock.yaml

squadronai

Incremental Review

Comments posted: 11

Configuration

Squadron Mode: essential

Commits Reviewed

e25a957ca31629d6d1b9a8a56b521b998a87b1a3...b5d033c3a81cd935dda7faa3d72dce8fe2d45f3a

Files Reviewed

packages/enhanced/src/lib/container/ContainerEntryModule.ts
packages/enhanced/src/lib/container/ModuleFederationPlugin.ts
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
packages/enhanced/src/prefetch.ts
packages/manifest/src/ManifestManager.ts
packages/runtime/src/core.ts
packages/runtime/src/index.ts
packages/runtime/src/module/index.ts
packages/runtime/src/plugins/generate-preload-assets.ts
packages/runtime/src/remote/index.ts
packages/sdk/src/constant.ts
packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

.changeset/light-items-battle.md
.github/workflows/e2e-manifest.yml
apps/manifest-demo/3009-webpack-provider/tsconfig.app.json
apps/manifest-demo/3009-webpack-provider/tsconfig.json
apps/manifest-demo/3010-rspack-provider/package.json
apps/manifest-demo/3010-rspack-provider/rspack.config.js
apps/manifest-demo/3010-rspack-provider/src/App.tsx
apps/manifest-demo/webpack-host/src/App.tsx
apps/manifest-demo/webpack-host/webpack.config.js
apps/modernjs/cypress/e2e/app.cy.ts
apps/modernjs/modern.config.ts
apps/modernjs/src/components/react-component.prefetch.ts
apps/modernjs/src/components/react-component.tsx
apps/modernjs/src/routes/page.tsx
apps/website-new/docs/en/guide/_meta.json
apps/website-new/docs/en/guide/performance/_meta.json
apps/website-new/docs/en/guide/performance/prefetch.mdx
apps/website-new/docs/public/guide/performance/data-prefetch/common.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/log.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/prefetch.jpg
apps/website-new/docs/zh/guide/_meta.json
apps/website-new/docs/zh/guide/performance/_meta.json
apps/website-new/docs/zh/guide/performance/prefetch.mdx
package.json
packages/data-prefetch/CHANGELOG.md
packages/data-prefetch/README.md
packages/data-prefetch/tests/babel.spec.ts
packages/data-prefetch/tests/prefetch.spec.ts
packages/data-prefetch/tests/react.spec.ts
packages/data-prefetch/jest.config.js
packages/data-prefetch/package.json
packages/data-prefetch/project.json
packages/data-prefetch/src/cli/babel.ts
packages/data-prefetch/src/cli/index.ts
packages/data-prefetch/src/common/constant.ts
packages/data-prefetch/src/common/index.ts
packages/data-prefetch/src/common/node-utils.ts
packages/data-prefetch/src/common/runtime-utils.ts
packages/data-prefetch/src/index.ts
packages/data-prefetch/src/logger/index.ts
packages/data-prefetch/src/plugin.ts
packages/data-prefetch/src/prefetch.ts
packages/data-prefetch/src/react/hooks.ts
packages/data-prefetch/src/react/index.ts
packages/data-prefetch/src/react/utils.ts
packages/data-prefetch/src/shared/index.ts
packages/data-prefetch/src/universal/index.ts
packages/data-prefetch/tsconfig.json
packages/data-prefetch/tsup.config.ts
packages/enhanced/package.json
packages/manifest/tsconfig.json
packages/webpack-bundler-runtime/src/initContainerEntry.ts
packages/webpack-bundler-runtime/src/types.ts
pnpm-lock.yaml

squadronai · 2024-09-11T10:07:51Z

packages/enhanced/src/lib/container/ContainerEntryModule.ts

@@ -293,7 +294,9 @@ class ContainerEntryModule extends Module {
          '})',
        ],
      )};`,
+      PrefetchPlugin.setRemoteIdentifier(),


The PrefetchPlugin.setRemoteIdentifier() call is inserted directly into the generated code. This might lead to issues if the plugin is not properly initialized or if its API changes. Consider wrapping this call in a try-catch block to handle potential errors gracefully:

Suggested change

PrefetchPlugin.setRemoteIdentifier(),

try {

PrefetchPlugin.setRemoteIdentifier();

} catch (error) {

console.warn('Failed to set remote identifier for prefetching:', error);

}

This change ensures that any errors during the prefetch setup won't break the entire module initialization process.

squadronai · 2024-09-11T10:07:52Z

packages/enhanced/src/lib/container/ContainerEntryModule.ts

      `${initRuntimeModuleGetter}`,
+      PrefetchPlugin.removeRemoteIdentifier(),


Similar to the setRemoteIdentifier call, the removeRemoteIdentifier call should also be wrapped in a try-catch block for error handling:

Suggested change

PrefetchPlugin.removeRemoteIdentifier(),

try {

PrefetchPlugin.removeRemoteIdentifier();

} catch (error) {

console.warn('Failed to remove remote identifier for prefetching:', error);

}

This ensures consistent error handling for both prefetch-related operations.

squadronai · 2024-09-11T10:07:52Z

packages/enhanced/src/lib/container/ContainerEntryModule.ts

@@ -16,6 +16,7 @@ import type {
  ResolverWithOptions,
  WebpackOptions,
 } from 'webpack/lib/Module';
+import { PrefetchPlugin } from '@module-federation/data-prefetch/cli';


The import statement for the PrefetchPlugin suggests that it's coming from a CLI package. It's unusual to import runtime functionality from a CLI package. Consider moving the PrefetchPlugin to a runtime package or creating a separate runtime package for data prefetching functionality. This would improve the separation of concerns and potentially reduce bundle size by not including unnecessary CLI code in the runtime.

Suggested change

import { PrefetchPlugin } from '@module-federation/data-prefetch/cli';

import { PrefetchPlugin } from '@module-federation/data-prefetch/runtime';

This change assumes you've refactored the project structure to separate CLI and runtime concerns.

squadronai · 2024-09-11T10:07:52Z

packages/manifest/src/ManifestManager.ts

+    let prefetchInterface = false;
+    const prefetchFilePath = path.resolve(
+      compiler.options.context || process.cwd(),
+      `node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`,
+    );
+    const existPrefetch = fs.existsSync(prefetchFilePath);
+    if (existPrefetch) {
+      const content = fs.readFileSync(prefetchFilePath).toString();
+      if (content) {
+        prefetchInterface = true;
+      }
+    }
+    stats.metaData.prefetchInterface = prefetchInterface;


Consider extracting the prefetch interface check into a separate method for better readability and reusability. This will also make the generateManifest method less cluttered. Here's a suggestion:

Suggested change

let prefetchInterface = false;

const prefetchFilePath = path.resolve(

compiler.options.context || process.cwd(),

`node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`,

);

const existPrefetch = fs.existsSync(prefetchFilePath);

if (existPrefetch) {

const content = fs.readFileSync(prefetchFilePath).toString();

if (content) {

prefetchInterface = true;

}

}

stats.metaData.prefetchInterface = prefetchInterface;

private checkPrefetchInterface(compiler: Compiler, stats: Stats): boolean {

const prefetchFilePath = path.resolve(

compiler.options.context || process.cwd(),

`node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`

);

if (fs.existsSync(prefetchFilePath)) {

const content = fs.readFileSync(prefetchFilePath).toString();

return !!content;

}

return false;

}

// In generateManifest method:

stats.metaData.prefetchInterface = this.checkPrefetchInterface(compiler, stats);

This change improves code organization and makes the prefetch interface check more modular.

squadronai · 2024-09-11T10:07:52Z

packages/manifest/src/ManifestManager.ts

      return sum;
    }, [] as ManifestRemote[]);


The code for processing manifest.exposes, manifest.shared, and manifest.remotes is repetitive. Consider creating a helper function to reduce duplication. Here's a suggestion:

Suggested change

return sum;

}, [] as ManifestRemote[]);

private processManifestArray<T, U>(

items: T[],

transformer: (item: T) => U

): U[] {

return items.reduce((sum, cur) => {

sum.push(transformer(cur));

return sum;

}, [] as U[]);

}

// Usage in generateManifest:

manifest.exposes = this.processManifestArray(stats.exposes, (cur) => ({

id: cur.id,

name: cur.name,

assets: cur.assets,

path: cur.path,

}));

manifest.shared = this.processManifestArray(stats.shared, (cur) => ({

id: cur.id,

name: cur.name,

version: cur.version,

singleton: cur.singleton,

requiredVersion: cur.requiredVersion,

hash: cur.hash,

assets: cur.assets,

}));

manifest.remotes = this.processManifestArray(stats.remotes, (cur) => {

const remote: ManifestRemote = {

federationContainerName: cur.federationContainerName,

moduleName: cur.moduleName,

alias: cur.alias,

};

if ('entry' in cur) {

remote.entry = cur.entry;

} else if ('version' in cur) {

remote.entry = cur.version;

}

return remote;

});

This change reduces code duplication and improves maintainability.

squadronai · 2024-09-11T10:07:52Z

packages/runtime/src/module/index.ts

+    expose: string,
+    options?: { loadFactory?: boolean },
+    remoteSnapshot?: ModuleInfo,
+  ) {
    const { loadFactory = true } = options || { loadFactory: true };


Consider using object destructuring with default values for cleaner option handling:

Suggested change

const { loadFactory = true } = options || { loadFactory: true };

const { loadFactory = true } = options ?? {};

This approach eliminates the need for the fallback object and makes the default value more explicit.

squadronai · 2024-09-11T10:07:52Z

packages/runtime/src/plugins/generate-preload-assets.ts

            name: remoteInfo.name,
            remoteSnapshot: moduleInfoSnapshot,
            preloadConfig,
-            remote: remoteInfo,
+            remote: remoteInfo as Remote,
            origin,
          });


Consider adding a type annotation to the preloadInfo object for better clarity and type safety. This can help prevent potential type-related issues in the future and improve code readability. Here's a suggestion:

Suggested change

name: remoteInfo.name,

remoteSnapshot: moduleInfoSnapshot,

preloadConfig,

remote: remoteInfo,

remote: remoteInfo as Remote,

origin,

});

const preloadInfo: PreloadInfo = {

name: remoteInfo.name,

remoteSnapshot: moduleInfoSnapshot,

preloadConfig,

remote: remoteInfo as Remote,

origin,

};

You would need to define the PreloadInfo interface in the appropriate location, possibly in the types file. This change enhances type safety and makes the code more self-documenting.

squadronai · 2024-09-11T10:07:52Z

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

@@ -228,6 +232,7 @@ export interface ModuleFederationPluginOptions {
  dev?: boolean | PluginDevOptions;
  dts?: boolean | PluginDtsOptions;
  async?: boolean | AsyncBoundaryOptions;
+  dataPrefetch?: DataPrefetch;


Consider adding a comment to explain the purpose and usage of the dataPrefetch option. For example:

Suggested change

dataPrefetch?: DataPrefetch;

/**

* When enabled, allows remote modules to send their interface requests

* along with the module static resource in advance, improving load times.

*/

dataPrefetch?: DataPrefetch;

squadronai · 2024-09-11T10:07:52Z

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

@@ -228,6 +232,7 @@ export interface ModuleFederationPluginOptions {
  dev?: boolean | PluginDevOptions;
  dts?: boolean | PluginDtsOptions;
  async?: boolean | AsyncBoundaryOptions;
+  dataPrefetch?: DataPrefetch;
  virtualRuntimeEntry?: boolean;


It would be helpful to add a comment explaining the purpose and impact of the virtualRuntimeEntry option. For example:

Suggested change

virtualRuntimeEntry?: boolean;

/**

* When set to true, creates a virtual entry point for runtime,

* which can be useful for certain module federation setups.

*/

virtualRuntimeEntry?: boolean;

squadronai · 2024-09-11T10:07:52Z

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

  experiments?: {
    federationRuntime?: false | 'hoisted';


Consider adding a comment to explain the purpose of the experiments object and specifically the federationRun property. For example:

Suggested change

experiments?: {

federationRuntime?: false | 'hoisted';

/**

* Experimental features for the Module Federation Plugin.

* @property {boolean} federationRun - Enables experimental federation runtime features.

*/

experiments?: {

federationRun?: boolean;

};

squadronai

Incremental Review

Comments posted: 9

Configuration

Squadron Mode: essential

Commits Reviewed

81201b8b5170f7d0475049d016bad44a13318f7f...0c6250298fc62ae75445282d2876de9f47c4083f

Files Reviewed

packages/enhanced/src/lib/container/ContainerEntryModule.ts
packages/enhanced/src/lib/container/ModuleFederationPlugin.ts
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
packages/enhanced/src/prefetch.ts
packages/manifest/src/ManifestManager.ts
packages/runtime/src/core.ts
packages/runtime/src/index.ts
packages/runtime/src/module/index.ts
packages/runtime/src/plugins/generate-preload-assets.ts
packages/runtime/src/remote/index.ts
packages/sdk/src/constant.ts
packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

.changeset/light-items-battle.md
.github/workflows/e2e-manifest.yml
apps/manifest-demo/3009-webpack-provider/tsconfig.app.json
apps/manifest-demo/3009-webpack-provider/tsconfig.json
apps/manifest-demo/3010-rspack-provider/package.json
apps/manifest-demo/3010-rspack-provider/rspack.config.js
apps/manifest-demo/3010-rspack-provider/src/App.tsx
apps/manifest-demo/webpack-host/src/App.tsx
apps/manifest-demo/webpack-host/webpack.config.js
apps/modernjs/cypress/e2e/app.cy.ts
apps/modernjs/modern.config.ts
apps/modernjs/src/components/react-component.prefetch.ts
apps/modernjs/src/components/react-component.tsx
apps/modernjs/src/routes/page.tsx
apps/website-new/docs/en/guide/_meta.json
apps/website-new/docs/en/guide/performance/_meta.json
apps/website-new/docs/en/guide/performance/prefetch.mdx
apps/website-new/docs/public/guide/performance/data-prefetch/common.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/log.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/prefetch.jpg
apps/website-new/docs/zh/guide/_meta.json
apps/website-new/docs/zh/guide/performance/_meta.json
apps/website-new/docs/zh/guide/performance/prefetch.mdx
package.json
packages/data-prefetch/CHANGELOG.md
packages/data-prefetch/README.md
packages/data-prefetch/tests/babel.spec.ts
packages/data-prefetch/tests/prefetch.spec.ts
packages/data-prefetch/tests/react.spec.ts
packages/data-prefetch/jest.config.js
packages/data-prefetch/package.json
packages/data-prefetch/project.json
packages/data-prefetch/src/cli/babel.ts
packages/data-prefetch/src/cli/index.ts
packages/data-prefetch/src/common/constant.ts
packages/data-prefetch/src/common/index.ts
packages/data-prefetch/src/common/node-utils.ts
packages/data-prefetch/src/common/runtime-utils.ts
packages/data-prefetch/src/index.ts
packages/data-prefetch/src/logger/index.ts
packages/data-prefetch/src/plugin.ts
packages/data-prefetch/src/prefetch.ts
packages/data-prefetch/src/react/hooks.ts
packages/data-prefetch/src/react/index.ts
packages/data-prefetch/src/react/utils.ts
packages/data-prefetch/src/shared/index.ts
packages/data-prefetch/src/universal/index.ts
packages/data-prefetch/tsconfig.json
packages/data-prefetch/tsup.config.ts
packages/enhanced/package.json
packages/manifest/tsconfig.json
packages/webpack-bundler-runtime/src/initContainerEntry.ts
packages/webpack-bundler-runtime/src/types.ts
pnpm-lock.yaml

squadronai · 2024-09-12T02:38:12Z

packages/enhanced/src/lib/container/ContainerEntryModule.ts

@@ -16,6 +16,7 @@ import type {
  ResolverWithOptions,
  WebpackOptions,
 } from 'webpack/lib/Module';
+import { PrefetchPlugin } from '@module-federation/data-prefetch/cli';


The import of PrefetchPlugin from '@module-federation/data-prefetch/cli' is a new addition that supports the interface data prefetch feature. Ensure that this dependency is properly documented in the project's README or relevant documentation to inform other developers about this new functionality.

squadronai · 2024-09-12T02:38:12Z

packages/enhanced/src/lib/container/ContainerEntryModule.ts

+      PrefetchPlugin.setRemoteIdentifier(),
      `${initRuntimeModuleGetter}`,
+      PrefetchPlugin.removeRemoteIdentifier(),


The usage of PrefetchPlugin.setRemoteIdentifier() and PrefetchPlugin.removeRemoteIdentifier() suggests that you're setting up a context for prefetching data. Consider adding a brief comment explaining the purpose of these calls and how they relate to the data prefetching feature. For example:

Suggested change

PrefetchPlugin.setRemoteIdentifier(),

`${initRuntimeModuleGetter}`,

PrefetchPlugin.removeRemoteIdentifier(),

// Set up context for data prefetching

PrefetchPlugin.setRemoteIdentifier(),

`${initRuntimeModuleGetter}`,

// Clean up prefetching context

PrefetchPlugin.removeRemoteIdentifier(),

This will improve code readability and help other developers understand the purpose of these method calls.

squadronai · 2024-09-12T02:38:12Z

packages/manifest/src/ManifestManager.ts

      return sum;
    }, [] as ManifestRemote[]);

+    let prefetchInterface = false;
+    const prefetchFilePath = path.resolve(
+      compiler.options.context || process.cwd(),
+      `node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`,
+    );
+    const existPrefetch = fs.existsSync(prefetchFilePath);
+    if (existPrefetch) {
+      const content = fs.readFileSync(prefetchFilePath).toString();
+      if (content) {
+        prefetchInterface = true;
+      }
+    }
+    stats.metaData.prefetchInterface = prefetchInterface;


Consider extracting the prefetch interface check into a separate method for better readability and reusability. This will also make the generateManifest method less cluttered. Here's a suggestion:

Suggested change

return sum;

}, [] as ManifestRemote[]);

let prefetchInterface = false;

const prefetchFilePath = path.resolve(

compiler.options.context || process.cwd(),

`node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`,

);

const existPrefetch = fs.existsSync(prefetchFilePath);

if (existPrefetch) {

const content = fs.readFileSync(prefetchFilePath).toString();

if (content) {

prefetchInterface = true;

}

}

stats.metaData.prefetchInterface = prefetchInterface;

private checkPrefetchInterface(compiler: Compiler, stats: Stats): boolean {

const prefetchFilePath = path.resolve(

compiler.options.context || process.cwd(),

`node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`

);

if (fs.existsSync(prefetchFilePath)) {

const content = fs.readFileSync(prefetchFilePath).toString();

return !!content;

}

return false;

}

// In generateManifest method:

stats.metaData.prefetchInterface = this.checkPrefetchInterface(compiler, stats);

This change improves code organization and makes the prefetch interface check more modular.

squadronai · 2024-09-12T02:38:12Z

packages/manifest/src/ManifestManager.ts

@@ -101,6 +105,20 @@ class ManifestManager {
      return sum;


The code for processing manifest.exposes, manifest.shared, and manifest.remotes is repetitive. Consider creating a helper function to reduce duplication. Here's a suggestion:

Suggested change

return sum;

private processManifestArray<T, U>(

items: T[],

transformer: (item: T) => U

): U[] {

return items.reduce((sum, cur) => {

sum.push(transformer(cur));

return sum;

}, [] as U[]);

}

// Usage in generateManifest:

manifest.exposes = this.processManifestArray(stats.exposes, (cur) => ({

id: cur.id,

name: cur.name,

assets: cur.assets,

path: cur.path,

}));

manifest.shared = this.processManifestArray(stats.shared, (cur) => ({

id: cur.id,

name: cur.name,

version: cur.version,

singleton: cur.singleton,

requiredVersion: cur.requiredVersion,

hash: cur.hash,

assets: cur.assets,

}));

manifest.remotes = this.processManifestArray(stats.remotes, (cur) => {

const remote: ManifestRemote = {

federationContainerName: cur.federationContainerName,

moduleName: cur.moduleName,

alias: cur.alias,

};

if ('entry' in cur) {

remote.entry = cur.entry;

} else if ('version' in cur) {

remote.entry = cur.version;

}

return remote;

});

This change reduces code duplication and improves maintainability.

squadronai · 2024-09-12T02:38:12Z

packages/manifest/src/ManifestManager.ts

+      }
+    }
+    stats.metaData.prefetchInterface = prefetchInterface;
+
    this._manifest = manifest;

    const manifestFileName = this.fileName;


Consider adding error handling for the case where additionalData is provided but fails. This will make the code more robust. Here's a suggestion:

Suggested change

const manifestFileName = this.fileName;

if (additionalData) {

try {

const ret = await additionalData({

manifest: this._manifest,

stats,

pluginOptions: this._options,

compiler,

compilation,

bundler,

});

this._manifest = ret || this._manifest;

} catch (error) {

console.error('Error processing additional data:', error);

// Optionally, you can add the error to the compilation warnings or errors

compilation.warnings.push(new Error('Failed to process additional manifest data'));

}

}

This change adds error handling to prevent the entire process from failing if additionalData throws an error.

squadronai · 2024-09-12T02:38:13Z

packages/runtime/src/module/index.ts

+    expose: string,
+    options?: { loadFactory?: boolean },
+    remoteSnapshot?: ModuleInfo,
+  ) {
    const { loadFactory = true } = options || { loadFactory: true };


Consider using object destructuring with default values for better consistency and readability:

Suggested change

const { loadFactory = true } = options || { loadFactory: true };

const { loadFactory = true } = options ?? {};

This approach is more consistent with modern JavaScript practices and clearly shows the default value for loadFactory.

squadronai · 2024-09-12T02:38:13Z

packages/runtime/src/plugins/generate-preload-assets.ts

            name: remoteInfo.name,
            remoteSnapshot: moduleInfoSnapshot,
            preloadConfig,
-            remote: remoteInfo,
+            remote: remoteInfo as Remote,
            origin,
          });


Consider adding a type annotation to the preloadInfo object for better clarity and type safety. This can help prevent potential type-related issues in the future and improve code readability. Here's a suggestion:

Suggested change

name: remoteInfo.name,

remoteSnapshot: moduleInfoSnapshot,

preloadConfig,

remote: remoteInfo,

remote: remoteInfo as Remote,

origin,

});

const preloadInfo: PreloadInfo = {

name: remoteInfo.name,

remoteSnapshot: moduleInfoSnapshot,

preloadConfig,

remote: remoteInfo as Remote,

origin,

};

You would need to define the PreloadInfo interface in the appropriate location, possibly in the types file. This change enhances type safety and makes the code more self-documenting.

squadronai · 2024-09-12T02:38:13Z

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

 export interface AdditionalDataOptions {
  stats: Stats;


Consider adding a comment to explain the purpose and contents of the AdditionalDataOptions interface. For example:

Suggested change

export interface AdditionalDataOptions {

stats: Stats;

/**

* Additional data options for the Module Federation Plugin.

* This interface includes statistics about the module.

*/

export interface AdditionalDataOptions {

stats: Stats;

This helps developers understand the purpose and contents of this interface at a glance.

squadronai · 2024-09-12T02:38:13Z

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

  dev?: boolean | PluginDevOptions;
  dts?: boolean | PluginDtsOptions;
  async?: boolean | AsyncBoundaryOptions;
+  dataPrefetch?: DataPrefetch;
  virtualRuntimeEntry?: boolean;
  experiments?: {
    federationRuntime?: false | 'hoisted';


Consider adding comments to explain the purpose of each option in this interface. For example:

Suggested change

dev?: boolean | PluginDevOptions;

dts?: boolean | PluginDtsOptions;

async?: boolean | AsyncBoundaryOptions;

dataPrefetch?: DataPrefetch;

virtualRuntimeEntry?: boolean;

experiments?: {

federationRuntime?: false | 'hoisted';

/**

* Enable development mode or specify development options.

*/

dev?: boolean | PluginDevOptions;

/**

* Enable TypeScript declaration file generation or specify options.

*/

dts?: boolean | PluginDtsOptions;

/**

* Enable asynchronous loading or specify async boundary options.

*/

async?: boolean | AsyncBoundaryOptions;

/**

* Enable data prefetching for remote modules.

*/

dataPrefetch?: DataPrefetch;

/**

* Enable virtual runtime entry.

*/

virtualRuntimeEntry?: boolean;

/**

* Experimental features.

*/

experiments?: {

federationRun

These comments provide more context about each option, making the code more self-documenting and easier to understand.

squadronai

Incremental Review

Comments posted: 9

Configuration

Squadron Mode: essential

Commits Reviewed

4a79d27662c70232dac3dc5ee651dadb16d833be...319e4c5b7520710c2a44f69a82bc0f331a9699b4

Files Reviewed

packages/enhanced/src/lib/container/ContainerEntryModule.ts
packages/enhanced/src/lib/container/ModuleFederationPlugin.ts
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
packages/enhanced/src/prefetch.ts
packages/manifest/src/ManifestManager.ts
packages/runtime/src/core.ts
packages/runtime/src/index.ts
packages/runtime/src/module/index.ts
packages/runtime/src/plugins/generate-preload-assets.ts
packages/runtime/src/remote/index.ts
packages/sdk/src/constant.ts
packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

.changeset/light-items-battle.md
apps/manifest-demo/3009-webpack-provider/tsconfig.app.json
apps/manifest-demo/3009-webpack-provider/tsconfig.json
apps/manifest-demo/3010-rspack-provider/package.json
apps/manifest-demo/3010-rspack-provider/rspack.config.js
apps/manifest-demo/3010-rspack-provider/src/App.tsx
apps/manifest-demo/webpack-host/src/App.tsx
apps/manifest-demo/webpack-host/webpack.config.js
apps/modernjs/cypress/e2e/app.cy.ts
apps/modernjs/modern.config.ts
apps/modernjs/src/components/react-component.prefetch.ts
apps/modernjs/src/components/react-component.tsx
apps/modernjs/src/routes/page.tsx
apps/website-new/docs/en/guide/_meta.json
apps/website-new/docs/en/guide/performance/_meta.json
apps/website-new/docs/en/guide/performance/prefetch.mdx
apps/website-new/docs/public/guide/performance/data-prefetch/common.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/log.jpg
apps/website-new/docs/public/guide/performance/data-prefetch/prefetch.jpg
apps/website-new/docs/zh/guide/_meta.json
apps/website-new/docs/zh/guide/performance/_meta.json
apps/website-new/docs/zh/guide/performance/prefetch.mdx
package.json
packages/data-prefetch/CHANGELOG.md
packages/data-prefetch/README.md
packages/data-prefetch/tests/babel.spec.ts
packages/data-prefetch/tests/prefetch.spec.ts
packages/data-prefetch/tests/react.spec.ts
packages/data-prefetch/jest.config.js
packages/data-prefetch/package.json
packages/data-prefetch/project.json
packages/data-prefetch/src/cli/babel.ts
packages/data-prefetch/src/cli/index.ts
packages/data-prefetch/src/common/constant.ts
packages/data-prefetch/src/common/index.ts
packages/data-prefetch/src/common/node-utils.ts
packages/data-prefetch/src/common/runtime-utils.ts
packages/data-prefetch/src/index.ts
packages/data-prefetch/src/logger/index.ts
packages/data-prefetch/src/plugin.ts
packages/data-prefetch/src/prefetch.ts
packages/data-prefetch/src/react/hooks.ts
packages/data-prefetch/src/react/index.ts
packages/data-prefetch/src/react/utils.ts
packages/data-prefetch/src/shared/index.ts
packages/data-prefetch/src/universal/index.ts
packages/data-prefetch/tsconfig.json
packages/data-prefetch/tsup.config.ts
packages/enhanced/package.json
packages/manifest/tsconfig.json
packages/webpack-bundler-runtime/src/initContainerEntry.ts
packages/webpack-bundler-runtime/src/types.ts
pnpm-lock.yaml

squadronai · 2024-09-12T03:13:45Z

packages/enhanced/src/lib/container/ContainerEntryModule.ts

@@ -16,6 +16,7 @@ import type {
  ResolverWithOptions,
  WebpackOptions,
 } from 'webpack/lib/Module';
+import { PrefetchPlugin } from '@module-federation/data-prefetch/cli';


The import of PrefetchPlugin from '@module-federation/data-prefetch/cli' is a new addition that supports the interface data prefetch feature. Ensure that this dependency is properly documented in the project's README or relevant documentation to inform other developers about this new functionality.

squadronai · 2024-09-12T03:13:45Z

packages/enhanced/src/lib/container/ContainerEntryModule.ts

+      PrefetchPlugin.setRemoteIdentifier(),
      `${initRuntimeModuleGetter}`,
+      PrefetchPlugin.removeRemoteIdentifier(),


The usage of PrefetchPlugin.setRemoteIdentifier() and PrefetchPlugin.removeRemoteIdentifier() suggests that you're setting up a context for prefetching data. Consider adding a brief comment explaining the purpose of these calls and how they relate to the data prefetching feature. For example:

Suggested change

PrefetchPlugin.setRemoteIdentifier(),

`${initRuntimeModuleGetter}`,

PrefetchPlugin.removeRemoteIdentifier(),

// Set up context for data prefetching

PrefetchPlugin.setRemoteIdentifier(),

`${initRuntimeModuleGetter}`,

// Clean up prefetching context

PrefetchPlugin.removeRemoteIdentifier(),

This will improve code readability and make it easier for other developers to understand the purpose of these method calls.

squadronai · 2024-09-12T03:13:45Z

packages/manifest/src/ManifestManager.ts

+    let prefetchInterface = false;
+    const prefetchFilePath = path.resolve(
+      compiler.options.context || process.cwd(),
+      `node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`,
+    );
+    const existPrefetch = fs.existsSync(prefetchFilePath);
+    if (existPrefetch) {
+      const content = fs.readFileSync(prefetchFilePath).toString();
+      if (content) {
+        prefetchInterface = true;
+      }
+    }
+    stats.metaData.prefetchInterface = prefetchInterface;


Consider extracting the prefetch interface check into a separate method for better readability and reusability. This will also make the generateManifest method less cluttered. Here's a suggestion:

Suggested change

let prefetchInterface = false;

const prefetchFilePath = path.resolve(

compiler.options.context || process.cwd(),

`node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`,

);

const existPrefetch = fs.existsSync(prefetchFilePath);

if (existPrefetch) {

const content = fs.readFileSync(prefetchFilePath).toString();

if (content) {

prefetchInterface = true;

}

}

stats.metaData.prefetchInterface = prefetchInterface;

private checkPrefetchInterface(compiler: Compiler, stats: Stats): boolean {

const prefetchFilePath = path.resolve(

compiler.options.context || process.cwd(),

`node_modules/.mf/${encodeName(stats.name)}/${MFPrefetchCommon.fileName}`

);

if (fs.existsSync(prefetchFilePath)) {

const content = fs.readFileSync(prefetchFilePath).toString();

return !!content;

}

return false;

}

// In generateManifest method:

stats.metaData.prefetchInterface = this.checkPrefetchInterface(compiler, stats);

This change improves code organization and makes the prefetch interface check more modular.

squadronai · 2024-09-12T03:13:45Z

packages/manifest/src/ManifestManager.ts

      return sum;
    }, [] as ManifestRemote[]);


The code for processing manifest.exposes, manifest.shared, and manifest.remotes is repetitive. Consider creating a helper function to reduce duplication. Here's a suggestion:

Suggested change

return sum;

}, [] as ManifestRemote[]);

private processManifestArray<T, U>(

items: T[],

transformer: (item: T) => U

): U[] {

return items.reduce((sum, cur) => {

sum.push(transformer(cur));

return sum;

}, [] as U[]);

}

// Usage in generateManifest:

manifest.exposes = this.processManifestArray(stats.exposes, (cur) => ({

id: cur.id,

name: cur.name,

assets: cur.assets,

path: cur.path,

}));

manifest.shared = this.processManifestArray(stats.shared, (cur) => ({

id: cur.id,

name: cur.name,

version: cur.version,

singleton: cur.singleton,

requiredVersion: cur.requiredVersion,

hash: cur.hash,

assets: cur.assets,

}));

manifest.remotes = this.processManifestArray(stats.remotes, (cur) => {

const remote: ManifestRemote = {

federationContainerName: cur.federationContainerName,

moduleName: cur.moduleName,

alias: cur.alias,

};

if ('entry' in cur) {

remote.entry = cur.entry;

} else if ('version' in cur) {

remote.entry = cur.version;

}

return remote;

});

This change reduces code duplication and improves maintainability.

squadronai · 2024-09-12T03:13:45Z

packages/manifest/src/ManifestManager.ts

+      }
+    }
+    stats.metaData.prefetchInterface = prefetchInterface;
+
    this._manifest = manifest;

    const manifestFileName = this.fileName;


Consider adding error handling for the case where additionalData is provided but fails. This will make the code more robust. Here's a suggestion:

Suggested change

const manifestFileName = this.fileName;

if (additionalData) {

try {

const ret = await additionalData({

manifest: this._manifest,

stats,

pluginOptions: this._options,

compiler,

compilation,

bundler,

});

this._manifest = ret || this._manifest;

} catch (error) {

console.error('Error processing additional data:', error);

// Optionally, you can add the error to the compilation warnings or errors

compilation.warnings.push(new Error('Failed to process additional manifest data'));

}

}

This change adds error handling to prevent the entire process from failing if additionalData throws an error.

squadronai · 2024-09-12T03:13:45Z

packages/runtime/src/module/index.ts

@@ -100,6 +105,8 @@ class Module {



Consider adding more specific error handling for the remoteEntryExports.init call. This could help in diagnosing issues more easily during the initialization process.

Suggested change

try {

await remoteEntryExports.init(

initContainerOptions.shareScope,

initContainerOptions.initScope,

initContainerOptions.remoteEntryInitOptions,

);

} catch (error) {

console.error(`Failed to initialize remote entry for ${this.remoteInfo.name}:`, error);

throw error;

}

This change adds a try-catch block to provide more context in case of an initialization error, which could be helpful for debugging in complex federated module setups.

squadronai · 2024-09-12T03:13:46Z

packages/runtime/src/plugins/generate-preload-assets.ts

            name: remoteInfo.name,
            remoteSnapshot: moduleInfoSnapshot,
            preloadConfig,
-            remote: remoteInfo,
+            remote: remoteInfo as Remote,
            origin,
          });


Consider adding a type annotation to the preloadInfo object for better clarity and type safety. This can help prevent potential type-related issues in the future and improve code readability. Here's a suggestion:

Suggested change

name: remoteInfo.name,

remoteSnapshot: moduleInfoSnapshot,

preloadConfig,

remote: remoteInfo,

remote: remoteInfo as Remote,

origin,

});

const preloadInfo: PreloadInfo = {

name: remoteInfo.name,

remoteSnapshot: moduleInfoSnapshot,

preloadConfig,

remote: remoteInfo as Remote,

origin,

};

You would need to define the PreloadInfo interface in the appropriate location, possibly in the types file. This change enhances type safety and makes the code more self-documenting.

squadronai · 2024-09-12T03:13:46Z

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

 export interface AdditionalDataOptions {
  stats: Stats;


Consider adding a comment to explain the purpose and usage of the AdditionalDataOptions interface. For example:

Suggested change

export interface AdditionalDataOptions {

stats: Stats;

/**

* Additional options for data-related configurations.

*/

export interface AdditionalDataOptions {

stats: Stats;

This helps developers understand the context and purpose of this interface.

squadronai · 2024-09-12T03:13:46Z

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts

  dev?: boolean | PluginDevOptions;
  dts?: boolean | PluginDtsOptions;
  async?: boolean | AsyncBoundaryOptions;
+  dataPrefetch?: DataPrefetch;
  virtualRuntimeEntry?: boolean;
  experiments?: {
    federationRuntime?: false | 'hoisted';


Consider adding comments to explain the purpose of each option in this interface. For example:

Suggested change

dev?: boolean | PluginDevOptions;

dts?: boolean | PluginDtsOptions;

async?: boolean | AsyncBoundaryOptions;

dataPrefetch?: DataPrefetch;

virtualRuntimeEntry?: boolean;

experiments?: {

federationRuntime?: false | 'hoisted';

/**

* Enable development mode or specify development options.

*/

dev?: boolean | PluginDevOptions;

/**

* Enable TypeScript declaration file generation or specify DTS options.

*/

dts?: boolean | PluginDtsOptions;

/**

* Enable asynchronous loading or specify async boundary options.

*/

async?: boolean | AsyncBoundaryOptions;

/**

* Enable data prefetching for remote modules.

*/

dataPrefetch?: DataPrefetch;

/**

* Enable virtual runtime entry.

*/

virtualRuntimeEntry?: boolean;

/**

* Experimental features configuration.

*/

experiments?: {

federationRun

These comments provide more context about each option, making the code more self-documenting and easier to understand.

nyqykk added 2 commits May 27, 2024 17:46

feat: support data prefetch

cbcb5ed

chore: remove useless content

cf03c2e

github-actions bot added the change: feat label May 27, 2024

github-advanced-security bot found potential problems May 27, 2024

View reviewed changes

nyqykk added 13 commits May 27, 2024 17:53

chore: merge main branch

582d81f

chore: add publish config for pkg

3dc0556

feat: support enable data prefetch

f9faa8e

chore: sync main branch

47bcfec

feat: support rspack

666e621

chore: rename variable

450f8de

fix: fix expose collect assets do not filter entry point cause load e…

72b5502

…xtra file

Merge branch 'fix/filter-entry-point' into feat/data-prefetch

2f98955

refactor: rewrite data prefetch init code

1ec8046

chore: sync main branch

cc025b6

chore: add changeset

3ddab21

fix: fix preloadRemote error

96038e6

chore: remove handlePreloadModule hook

7a8d0fe

2heal1 reviewed Jul 4, 2024

View reviewed changes

apps/manifest-demo/3010-rspack-provider/src/App.tsx Show resolved Hide resolved

2heal1 reviewed Jul 4, 2024

View reviewed changes

packages/data-prefetch/README.md Outdated Show resolved Hide resolved

2heal1 reviewed Jul 4, 2024

View reviewed changes

packages/data-prefetch/src/prefetch.ts Outdated Show resolved Hide resolved

2heal1 reviewed Jul 4, 2024

View reviewed changes

packages/data-prefetch/package.json Show resolved Hide resolved

2heal1 reviewed Jul 4, 2024

View reviewed changes

packages/sdk/src/types/plugins/ModuleFederationPlugin.ts Show resolved Hide resolved

nyqykk added 5 commits July 29, 2024 15:36

docs: add docs

426740d

Revert "chore: remove handlePreloadModule hook"

1082eff

This reverts commit 7a8d0fe.

chore: sync main branch

a77a145

docs: add data prefetch doc

4d6b49e

docs: modify docs

6cf755b

nyqykk added 2 commits September 11, 2024 16:45

Merge branch 'main' into feat/data-prefetch

694f26d

Merge branch 'main' into feat/data-prefetch

575c454

squadronai bot reviewed Sep 11, 2024

View reviewed changes

Merge branch 'main' into feat/data-prefetch

b5d033c

squadronai bot reviewed Sep 11, 2024

View reviewed changes

Merge branch 'main' into feat/data-prefetch

0c62502

squadronai bot reviewed Sep 12, 2024

View reviewed changes

test: fix e2e test fail

319e4c5

squadronai bot reviewed Sep 12, 2024

View reviewed changes

nyqykk added 17 commits September 12, 2024 11:22

test: wait for modern project

016cb9b

test: wait for main project

80f5033

test: wait for modernjs project

cce42a5

chore: modify modernjs project config

d5ef7de

chore: add log for ci

aee7330

chore: wait for local ip

b890f31

chore: change tcp to http

c1dc6b0

chore: change to localhost

007b14e

chore: change adress

7a3f7a3

chore: add kill port

7b43a7a

chore: use ip to remove localhost

e43936b

chore: modify publich path

b9c1f85

fix: use federation name to remove user input id

4e1e3f8

Merge branch 'main' into feat/data-prefetch

cb476f1

fix: add default function id for universal prefetch

da7c166

test: fix test get instance error

70c7886

chore: remove useless file

62b029d

2heal1 approved these changes Sep 19, 2024

View reviewed changes

nyqykk merged commit 3070e26 into main Sep 19, 2024
17 checks passed

nyqykk deleted the feat/data-prefetch branch September 19, 2024 02:48

2heal1 mentioned this pull request Sep 19, 2024

Release v0.6.5 #2966

Merged

-      PrefetchPlugin.setRemoteIdentifier(),
+try {
+  PrefetchPlugin.setRemoteIdentifier();
+} catch (error) {
+  console.warn('Failed to set remote identifier for prefetching:', error);
+}

		`${initRuntimeModuleGetter}`,
		PrefetchPlugin.removeRemoteIdentifier(),

	import { PrefetchPlugin } from '@module-federation/data-prefetch/cli';
	import { PrefetchPlugin } from '@module-federation/data-prefetch/runtime';

-      return sum;
-    }, [] as ManifestRemote[]);
+private processManifestArray<T, U>(
+  items: T[],
+  transformer: (item: T) => U
+): U[] {
+  return items.reduce((sum, cur) => {
+    sum.push(transformer(cur));
+    return sum;
+  }, [] as U[]);
+}
+// Usage in generateManifest:
+manifest.exposes = this.processManifestArray(stats.exposes, (cur) => ({
+  id: cur.id,
+  name: cur.name,
+  assets: cur.assets,
+  path: cur.path,
+}));
+manifest.shared = this.processManifestArray(stats.shared, (cur) => ({
+  id: cur.id,
+  name: cur.name,
+  version: cur.version,
+  singleton: cur.singleton,
+  requiredVersion: cur.requiredVersion,
+  hash: cur.hash,
+  assets: cur.assets,
+}));
+manifest.remotes = this.processManifestArray(stats.remotes, (cur) => {
+  const remote: ManifestRemote = {
+    federationContainerName: cur.federationContainerName,
+    moduleName: cur.moduleName,
+    alias: cur.alias,
+  };
+  if ('entry' in cur) {
+    remote.entry = cur.entry;
+  } else if ('version' in cur) {
+    remote.entry = cur.version;
+  }
+  return remote;
+});

	const { loadFactory = true } = options \|\| { loadFactory: true };
	const { loadFactory = true } = options ?? {};

-    const manifestFileName = this.fileName;
+if (additionalData) {
+  try {
+    const ret = await additionalData({
+      manifest: this._manifest,
+      stats,
+      pluginOptions: this._options,
+      compiler,
+      compilation,
+      bundler,
+    });
+    this._manifest = ret || this._manifest;
+  } catch (error) {
+    console.error('Error processing additional data:', error);
+    // Optionally, you can add the error to the compilation warnings or errors
+    compilation.warnings.push(new Error('Failed to process additional manifest data'));
+  }
+}

+try {
+  await remoteEntryExports.init(
+    initContainerOptions.shareScope,
+    initContainerOptions.initScope,
+    initContainerOptions.remoteEntryInitOptions,
+  );
+} catch (error) {
+  console.error(`Failed to initialize remote entry for ${this.remoteInfo.name}:`, error);
+  throw error;
+}

feat: support interface data prefetch #2543

feat: support interface data prefetch #2543

Conversation

nyqykk commented May 27, 2024 • edited Loading

Description

Related Issue

Types of changes

Checklist

changeset-bot bot commented May 27, 2024 • edited Loading

🦋 Changeset detected

netlify bot commented May 27, 2024 • edited Loading

✅ Deploy Preview for module-federation-docs ready!

zhoushaw commented Jul 4, 2024

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot Sep 11, 2024

Choose a reason for hiding this comment

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

Choose a reason for hiding this comment

squadronai bot Sep 12, 2024

nyqykk commented May 27, 2024 •

edited

Loading

changeset-bot bot commented May 27, 2024 •

edited

Loading

netlify bot commented May 27, 2024 •

edited

Loading