chore: update NX libraries to v19 #2764

ScriptedAlchemy · 2024-07-17T19:42:38Z

Description

Related Issue

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have added tests to cover my changes.
All new and existing tests passed.
I have updated the documentation.

changeset-bot · 2024-07-17T19:42:41Z

⚠️ No Changeset found

Latest commit: c313095

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2024-07-17T19:42:55Z

✅ Deploy Preview for module-federation-docs ready!

Name	Link
🔨 Latest commit	`c313095`
🔍 Latest deploy log	https://app.netlify.com/sites/module-federation-docs/deploys/66f8bcc937f5b60008692e48
😎 Deploy Preview	https://deploy-preview-2764--module-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

# Conflicts: # pnpm-lock.yaml

squadronai

Summary

The pull request updates the NX libraries to version 19, focusing on improving compatibility, robustness, and reliability across several key components:

The runtimePlugin.ts file in the packages/node package has been updated to handle a new property USE_MAIN_CONTEXT_DEFAULT_LOADER from the vm.constants object, ensuring better compatibility with the latest NX libraries.
The load.ts file in the packages/runtime package has been updated to replace the assert utility function with the logger utility module, centralizing and standardizing the logging and assertion functionality used throughout the codebase.
The logger.ts file in the packages/sdk package introduces a new safeToString function to safely convert any input to a JSON string, and the safeGetLocalStorageItem function has been moved within the file, improving the robustness and reliability of the logging functionality.
The node.ts file in the packages/sdk package has been updated to use the vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER value when available, falling back to the importNodeModule function, to improve the handling of dynamic module imports in the context of the script node creation process.
The utils.ts file in the packages/sdk package has been updated to remove the /* @__PURE__ */ annotation from the function declarations, likely indicating a change in the build or bundling process.

These changes aim to ensure seamless integration with the latest version of the NX libraries, enhance the overall reliability and robustness of the codebase, and improve the handling of dynamic module imports and logging functionality.

File Summaries

File	Summary
packages/node/src/runtimePlugin.ts	The code changes update the `importModuleDynamically` function in the `runtimePlugin.ts` file to handle a new property `USE_MAIN_CONTEXT_DEFAULT_LOADER` from the `vm.constants` object. This change ensures compatibility with the latest version of the NX libraries and provides a more robust module loading mechanism.
packages/runtime/src/utils/load.ts	The code changes update the import statement for the `assert` utility function, replacing it with the `logger` utility module. This change likely aims to centralize and standardize the logging and assertion functionality used throughout the codebase.
packages/sdk/src/logger.ts	The code changes introduce a new function `safeToString` that safely converts any input to a JSON string, handling potential errors. Additionally, the existing `safeGetLocalStorageItem` function has been moved within the file. These changes aim to improve the robustness and reliability of the logging functionality in the SDK.
packages/sdk/src/node.ts	The code changes update the `importModuleDynamically` function in the `createScriptNode` method to use the `vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER` value if available, falling back to the `importNodeModule` function if not. This modification likely aims to improve the handling of dynamic module imports in the context of the script node creation process.
packages/sdk/src/utils.ts	The code changes in this file focus on updating the utility functions used for composing, encoding, and decoding names, as well as generating filenames for federation expose and share operations. The primary purpose of these changes is to remove the `/* @__PURE__ */` annotation from the function declarations, which likely indicates a change in the build or bundling process.

# Conflicts: # .gitignore # package.json # pnpm-lock.yaml

# Conflicts: # packages/storybook-addon/package.json # pnpm-lock.yaml

- Update eslint rules to disable no-unused-vars and no-unused-expressions - Refactor various container plugins to remove unused code and simplify logic

squadronai

Incremental Review

Comments posted: 2

Configuration

Squadron Mode: essential

Commits Reviewed

44ac346ef4212a17e4b2d611ba0e7948ba804947...4b719e2b09ace64c17e6ed5c473ebfbc41bcffcb

Files Reviewed

packages/enhanced/src/index.ts
packages/node/src/runtimePlugin.ts
packages/sdk/src/logger.ts
packages/sdk/src/node.ts
packages/sdk/src/utils.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

.eslintrc.json
.github/workflows/e2e-next-dev.yml
.github/workflows/e2e-next-prod.yml
.prettierignore
apps/3000-home/components/SharedNav.tsx
apps/3000-home/package.json
apps/3001-shop/package.json
apps/3002-checkout/package.json
apps/docs/src/en/modules/ROOT/pages/angular-way/mf-ssr-angular.adoc
apps/docs/src/en/modules/ROOT/pages/recipes/tailwind-mf.adoc
apps/manifest-demo/3009-webpack-provider/project.json
apps/manifest-demo/3009-webpack-provider/webpack.config.js
apps/manifest-demo/3010-rspack-provider/package.json
apps/manifest-demo/3010-rspack-provider/rspack.config.js
apps/manifest-demo/3010-rspack-provider/src/components/ButtonOldAnt.tsx
apps/manifest-demo/3011-rspack-manifest-provider/package.json
apps/manifest-demo/3011-rspack-manifest-provider/project.json
apps/manifest-demo/3011-rspack-manifest-provider/rspack.config.js
apps/manifest-demo/3011-rspack-manifest-provider/src/bootsrtap.jsx
apps/manifest-demo/3011-rspack-manifest-provider/src/index.js
apps/manifest-demo/3012-rspack-js-entry-provider/package.json
apps/manifest-demo/3012-rspack-js-entry-provider/project.json
apps/manifest-demo/3012-rspack-js-entry-provider/rspack.config.js
apps/manifest-demo/3012-rspack-js-entry-provider/src/bootstrap.jsx
apps/manifest-demo/3012-rspack-js-entry-provider/src/index.js
apps/manifest-demo/webpack-host/cypress/e2e/basic-usage.cy.ts
apps/manifest-demo/webpack-host/project.json
apps/manifest-demo/webpack-host/src/App.tsx
apps/manifest-demo/webpack-host/webpack.config.js
apps/node-dynamic-remote-new-version/project.json
apps/node-dynamic-remote-new-version/webpack.config.js
apps/node-dynamic-remote/project.json
apps/node-dynamic-remote/webpack.config.js
apps/node-local-remote/project.json
apps/node-local-remote/webpack.config.js
apps/node-remote/project.json
apps/node-remote/webpack.config.js
apps/react-ts-host/project.json
apps/react-ts-host/webpack.config.js
apps/react-ts-nested-remote/project.json
apps/react-ts-nested-remote/webpack.config.js
apps/react-ts-remote/project.json
apps/react-ts-remote/rspack.config.js
apps/react-ts-remote/webpack.config.js
apps/reactRemoteUI/project.json
apps/reactRemoteUI/webpack.config.js
apps/reactRemoteUI/webpack.config.prod.js
apps/reactStorybook/.storybook/main.js
apps/reactStorybook/.storybook/preview.js
apps/reactStorybook/project.json
apps/reactStorybook/webpack.config.js
apps/reactStorybook/webpack.config.prod.js
apps/router-demo/router-host-vue3-2100/package.json
apps/router-demo/router-remote3-2003/package.json
apps/runtime-demo/3005-runtime-host/project.json
apps/runtime-demo/3005-runtime-host/src/Remote2.tsx
apps/runtime-demo/3005-runtime-host/webpack.config.js
apps/runtime-demo/3006-runtime-remote/project.json
apps/runtime-demo/3006-runtime-remote/webpack.config.js
apps/runtime-demo/3007-runtime-remote/project.json
apps/runtime-demo/3007-runtime-remote/webpack.config.js
apps/website/project.json
nx.json
package.json
packages/chrome-devtools/.storybook/main.ts
packages/esbuild/rollup.config.js
packages/rspack/package.json
packages/rspack/rollup.config.js
packages/runtime/rollup.config.js
packages/sdk/rollup.config.js
packages/storybook-addon/package.json
packages/webpack-bundler-runtime/.swcrc
packages/webpack-bundler-runtime/rollup.config.js
pnpm-lock.yaml

squadronai · 2024-09-25T19:02:51Z

packages/node/src/runtimePlugin.ts

+                      //@ts-ignore
                      vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER ??
                      importNodeModule,


The use of @ts-ignore and optional chaining with a fallback suggests a potential type mismatch or uncertainty about the vm.constants property. Consider refactoring this to use a more type-safe approach:

Suggested change

//@ts-ignore

vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER ??

importNodeModule,

importModuleDynamically: vm.constants && 'USE_MAIN_CONTEXT_DEFAULT_LOADER' in vm.constants

? vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER

: importNodeModule,

This change eliminates the need for @ts-ignore and provides a more explicit check for the existence of the USE_MAIN_CONTEXT_DEFAULT_LOADER property.

squadronai · 2024-09-25T19:02:51Z

packages/sdk/src/node.ts

+            //@ts-ignore
            vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER ?? importNodeModule,


The use of @ts-ignore and optional chaining with a fallback suggests a potential type mismatch or uncertainty about the vm.constants property. Consider refactoring this to use a more type-safe approach:

Suggested change

//@ts-ignore

vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER ?? importNodeModule,

importModuleDynamically:

typeof vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER !== 'undefined'

? vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER

: importNodeModule,

This change eliminates the need for @ts-ignore and provides a more explicit check for the existence of USE_MAIN_CONTEXT_DEFAULT_LOADER.

squadronai

Incremental Review

Comments posted: 1

Configuration

Squadron Mode: essential

Commits Reviewed

3e2fd6fd3d6eb33f5d493d297b910b3ad2737b9f...6e4f9f7db36a0675ce26f88a2d131d38657b2d5a

Files Reviewed

packages/runtime/src/utils/load.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

.eslintrc.json
.github/workflows/e2e-next-dev.yml
.github/workflows/e2e-next-prod.yml
.prettierignore
apps/3000-home/components/SharedNav.tsx
apps/3000-home/package.json
apps/3001-shop/package.json
apps/3002-checkout/package.json
apps/docs/src/en/modules/ROOT/pages/angular-way/mf-ssr-angular.adoc
apps/docs/src/en/modules/ROOT/pages/recipes/tailwind-mf.adoc
apps/manifest-demo/3009-webpack-provider/project.json
apps/manifest-demo/3009-webpack-provider/webpack.config.js
apps/manifest-demo/3010-rspack-provider/package.json
apps/manifest-demo/3010-rspack-provider/rspack.config.js
apps/manifest-demo/3010-rspack-provider/src/components/ButtonOldAnt.tsx
apps/manifest-demo/3011-rspack-manifest-provider/package.json
apps/manifest-demo/3011-rspack-manifest-provider/project.json
apps/manifest-demo/3011-rspack-manifest-provider/rspack.config.js
apps/manifest-demo/3011-rspack-manifest-provider/src/bootsrtap.jsx
apps/manifest-demo/3011-rspack-manifest-provider/src/index.js
apps/manifest-demo/3012-rspack-js-entry-provider/package.json
apps/manifest-demo/3012-rspack-js-entry-provider/project.json
apps/manifest-demo/3012-rspack-js-entry-provider/rspack.config.js
apps/manifest-demo/3012-rspack-js-entry-provider/src/bootstrap.jsx
apps/manifest-demo/3012-rspack-js-entry-provider/src/index.js
apps/manifest-demo/webpack-host/cypress/e2e/basic-usage.cy.ts
apps/manifest-demo/webpack-host/project.json
apps/manifest-demo/webpack-host/src/App.tsx
apps/manifest-demo/webpack-host/webpack.config.js
apps/node-dynamic-remote-new-version/project.json
apps/node-dynamic-remote-new-version/webpack.config.js
apps/node-dynamic-remote/project.json
apps/node-dynamic-remote/webpack.config.js
apps/node-local-remote/project.json
apps/node-local-remote/webpack.config.js
apps/node-remote/project.json
apps/node-remote/webpack.config.js
apps/react-ts-host/project.json
apps/react-ts-host/webpack.config.js
apps/react-ts-nested-remote/project.json
apps/react-ts-nested-remote/webpack.config.js
apps/react-ts-remote/project.json
apps/react-ts-remote/rspack.config.js
apps/react-ts-remote/webpack.config.js
apps/reactRemoteUI/project.json
apps/reactRemoteUI/webpack.config.js
apps/reactRemoteUI/webpack.config.prod.js
apps/reactStorybook/.storybook/main.js
apps/reactStorybook/.storybook/preview.js
apps/reactStorybook/project.json
apps/reactStorybook/webpack.config.js
apps/reactStorybook/webpack.config.prod.js
apps/router-demo/router-host-vue3-2100/package.json
apps/router-demo/router-remote3-2003/package.json
apps/runtime-demo/3005-runtime-host/project.json
apps/runtime-demo/3005-runtime-host/src/Remote2.tsx
apps/runtime-demo/3005-runtime-host/webpack.config.js
apps/runtime-demo/3006-runtime-remote/project.json
apps/runtime-demo/3006-runtime-remote/webpack.config.js
apps/runtime-demo/3007-runtime-remote/project.json
apps/runtime-demo/3007-runtime-remote/webpack.config.js
apps/website/project.json
nx.json
package.json
packages/chrome-devtools/.storybook/main.ts
packages/esbuild/rollup.config.js
packages/rspack/package.json
packages/rspack/rollup.config.js
packages/runtime/rollup.config.js
packages/sdk/rollup.config.js
packages/storybook-addon/package.json
packages/webpack-bundler-runtime/.swcrc
packages/webpack-bundler-runtime/rollup.config.js
pnpm-lock.yaml

squadronai · 2024-09-25T21:19:27Z

packages/runtime/src/utils/load.ts

 async function loadEsmEntry({
  entry,


The loadEsmEntry function is defined here, but only its signature is visible. It appears to be handling the loading of ESM (ECMAScript Module) entries. This function likely plays a crucial role in the module federation system. Ensure that the implementation of this function (which is not visible in the provided snippet) properly handles asynchronous loading, error cases, and integrates well with the rest of the system.

# Conflicts: # packages/data-prefetch/rollup.config.js

squadronai

Incremental Review

Comments posted: 1

Configuration

Squadron Mode: essential

Commits Reviewed

affab373de6b4c547ac753c87ff96145b66ad0cb...3f3beb5c47b0b60771341c2ca748f01b4587dbaf

Files Reviewed

packages/node/src/runtimePlugin.ts
packages/runtime/src/utils/load.ts
packages/sdk/src/logger.ts
packages/sdk/src/node.ts
packages/sdk/src/utils.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

.eslintrc.json
.github/workflows/e2e-modern.yml
.github/workflows/e2e-next-dev.yml
.github/workflows/e2e-next-prod.yml
.prettierignore
apps/3000-home/components/SharedNav.tsx
apps/3000-home/package.json
apps/3001-shop/package.json
apps/3002-checkout/package.json
apps/docs/src/en/modules/ROOT/pages/angular-way/mf-ssr-angular.adoc
apps/docs/src/en/modules/ROOT/pages/recipes/tailwind-mf.adoc
apps/esbuild/package.json
apps/manifest-demo/3009-webpack-provider/project.json
apps/manifest-demo/3009-webpack-provider/webpack.config.js
apps/manifest-demo/3010-rspack-provider/package.json
apps/manifest-demo/3010-rspack-provider/rspack.config.js
apps/manifest-demo/3010-rspack-provider/src/components/ButtonOldAnt.tsx
apps/manifest-demo/3010-rspack-provider/tsconfig.app.json
apps/manifest-demo/3010-rspack-provider/tsconfig.json
apps/manifest-demo/3011-rspack-manifest-provider/package.json
apps/manifest-demo/3011-rspack-manifest-provider/project.json
apps/manifest-demo/3011-rspack-manifest-provider/rspack.config.js
apps/manifest-demo/3011-rspack-manifest-provider/src/bootsrtap.jsx
apps/manifest-demo/3011-rspack-manifest-provider/src/index.js
apps/manifest-demo/3012-rspack-js-entry-provider/package.json
apps/manifest-demo/3012-rspack-js-entry-provider/project.json
apps/manifest-demo/3012-rspack-js-entry-provider/rspack.config.js
apps/manifest-demo/3012-rspack-js-entry-provider/src/bootstrap.jsx
apps/manifest-demo/3012-rspack-js-entry-provider/src/index.js
apps/manifest-demo/webpack-host/cypress/e2e/basic-usage.cy.ts
apps/manifest-demo/webpack-host/package.json
apps/manifest-demo/webpack-host/project.json
apps/manifest-demo/webpack-host/src/App.tsx
apps/manifest-demo/webpack-host/webpack.config.js
apps/modernjs-ssr/dynamic-nested-remote/package.json
apps/modernjs-ssr/dynamic-remote-new-version/package.json
apps/modernjs-ssr/dynamic-remote/package.json
apps/modernjs-ssr/host/package.json
apps/modernjs-ssr/nested-remote/package.json
apps/modernjs-ssr/remote-new-version/package.json
apps/modernjs-ssr/remote/package.json
apps/modernjs/modern.config.ts
apps/modernjs/package.json
apps/node-dynamic-remote-new-version/project.json
apps/node-dynamic-remote-new-version/webpack.config.js
apps/node-dynamic-remote/project.json
apps/node-dynamic-remote/webpack.config.js
apps/node-local-remote/project.json
apps/node-local-remote/webpack.config.js
apps/node-remote/project.json
apps/node-remote/webpack.config.js
apps/react-ts-host/project.json
apps/react-ts-host/webpack.config.js
apps/react-ts-nested-remote/project.json
apps/react-ts-nested-remote/webpack.config.js
apps/react-ts-remote/project.json
apps/react-ts-remote/rspack.config.js
apps/react-ts-remote/webpack.config.js
apps/reactRemoteUI/project.json
apps/reactRemoteUI/webpack.config.js
apps/reactRemoteUI/webpack.config.prod.js
apps/reactStorybook/.storybook/main.js
apps/reactStorybook/.storybook/preview.js
apps/reactStorybook/project.json
apps/reactStorybook/webpack.config.js
apps/reactStorybook/webpack.config.prod.js
apps/router-demo/router-host-v5-2200/package.json
apps/router-demo/router-host-vue3-2100/package.json
apps/router-demo/router-remote1-2001/package.json
apps/router-demo/router-remote3-2003/package.json
apps/runtime-demo/3005-runtime-host/project.json
apps/runtime-demo/3005-runtime-host/src/Remote2.tsx
apps/runtime-demo/3005-runtime-host/webpack.config.js
apps/runtime-demo/3006-runtime-remote/project.json
apps/runtime-demo/3006-runtime-remote/webpack.config.js
apps/runtime-demo/3007-runtime-remote/project.json
apps/runtime-demo/3007-runtime-remote/webpack.config.js
apps/runtime-demo/3008-runtime-remote/package.json
apps/website/project.json
nx.json
package.json
packages/bridge/bridge-react-webpack-plugin/tests/mockRouterDir/router-v6/react-router-dom/package.json
packages/bridge/bridge-react/package.json
packages/chrome-devtools/.storybook/main.ts
packages/chrome-devtools/package.json
packages/chrome-devtools/src/utils/chrome/fast-refresh.ts
packages/data-prefetch/.swcrc
packages/data-prefetch/package.json
packages/data-prefetch/rollup.config.js
packages/enhanced/test/configCases/container/3-container-full/index.js
packages/esbuild/rollup.config.js
packages/modernjs/src/cli/index.ts
packages/rspack/package.json
packages/rspack/rollup.config.js
packages/runtime/rollup.config.js
packages/sdk/rollup.config.js
packages/storybook-addon/package.json
packages/utilities/package.json
packages/webpack-bundler-runtime/.swcrc
packages/webpack-bundler-runtime/rollup.config.js
pnpm-lock.yaml
webpack/package.json

squadronai · 2024-09-29T01:49:19Z

packages/node/src/runtimePlugin.ts

                    importModuleDynamically:
+                      //@ts-ignore
                      vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER ??
                      importNodeModule,


The use of @ts-ignore and optional chaining with a fallback suggests a potential type mismatch or uncertainty about the vm.constants property. Consider refactoring this to use a more type-safe approach:

Suggested change

importModuleDynamically:

//@ts-ignore

vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER ??

importNodeModule,

importModuleDynamically: vm.constants && 'USE_MAIN_CONTEXT_DEFAULT_LOADER' in vm.constants

? vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER

: importNodeModule,

This change eliminates the need for @ts-ignore and provides a more explicit check for the existence of the USE_MAIN_CONTEXT_DEFAULT_LOADER property.

# Conflicts: # packages/chrome-devtools/package.json # pnpm-lock.yaml

chore: update NX

3a3dcc5

ScriptedAlchemy added 3 commits July 18, 2024 04:01

chore: ignore vm.constants

b1c060e

Merge branch 'refs/heads/main' into nx-upgrade

f696216

# Conflicts: # pnpm-lock.yaml

chore: locks

1db1966

ScriptedAlchemy changed the title ~~chore: update NX~~ chore: update NX libraries to v19 Jul 22, 2024

chore: fix esbuild rollup error

f12c5ef

ScriptedAlchemy marked this pull request as ready for review July 22, 2024 04:12

chore: fix esbuild rollup error

92a6c38

ScriptedAlchemy force-pushed the nx-upgrade branch from 892f169 to 92a6c38 Compare July 22, 2024 05:30

ScriptedAlchemy added 2 commits August 21, 2024 16:07

chore: lint

a351cb1

chore: update deps

caa23e8

squadronai bot reviewed Aug 21, 2024

View reviewed changes

ScriptedAlchemy force-pushed the nx-upgrade branch from ca2baac to de96194 Compare August 22, 2024 23:40

chore: remove plugin

533bcd6

ScriptedAlchemy force-pushed the nx-upgrade branch from de96194 to 533bcd6 Compare August 23, 2024 20:13

ScriptedAlchemy and others added 13 commits August 30, 2024 17:45

Merge branch 'main' into nx-upgrade

565043f

# Conflicts: # .gitignore # package.json # pnpm-lock.yaml

chore: update lock file

cfa99e1

chore: update rspack builder tool

630d047

chore: update rspack builder tool

4907343

chore: update rspack builder tool

2c15957

fix: bump nx/rspack to latest for nx upgrade (#2920)

267025f

Merge branch 'main' into nx-upgrade

c45933d

# Conflicts: # packages/storybook-addon/package.json # pnpm-lock.yaml

chore: locks

7783680

fix: css config for rspack

f95697d

fix: css config for rspack

a09d901

fix: css config for rspack

cf46b35

fix: css config for rspack

b503279

fix: css config for rspack

c79bbd7

ScriptedAlchemy added 4 commits September 24, 2024 20:12

chore(enhanced): update eslint rules and refactor container plugins

228f433

- Update eslint rules to disable no-unused-vars and no-unused-expressions - Refactor various container plugins to remove unused code and simplify logic

Merge branch 'main' into nx-upgrade

d1c5fae

chore: update test scripts

fe8faa5

chore: update test scripts

4b719e2

ScriptedAlchemy force-pushed the nx-upgrade branch from c9344bf to 4b719e2 Compare September 25, 2024 19:01

module-federation deleted a comment from squadronai bot Sep 25, 2024

squadronai bot reviewed Sep 25, 2024

View reviewed changes

ScriptedAlchemy and others added 4 commits September 25, 2024 13:33

Merge branch 'main' into nx-upgrade

27d86fd

Merge branch 'main' into nx-upgrade

3e2fd6f

Merge remote-tracking branch 'origin/nx-upgrade' into nx-upgrade

8070c77

fix: remove circular dependency

6e4f9f7

squadronai bot reviewed Sep 25, 2024

View reviewed changes

ScriptedAlchemy and others added 8 commits September 25, 2024 14:57

fix: remove circular dependency

864d4b7

fix: remove circular dependency

b6b723d

chore: update react version

002bbe5

chore: update react version

f3ead2c

fix: upgrade nx ci error

8b03895

fix: upgrade nx ci error (#2998)

246dbde

chore: update swcrc for data prefetch

e7ddff0

Merge branch 'fix/ci-upgrade-nx' into nx-upgrade

e4ae795

# Conflicts: # packages/data-prefetch/rollup.config.js

2heal1 approved these changes Sep 27, 2024

View reviewed changes

ScriptedAlchemy and others added 2 commits September 28, 2024 00:16

Merge branch 'main' into nx-upgrade

1fedc4b

chore: locks

3f3beb5

squadronai bot reviewed Sep 29, 2024

View reviewed changes

ScriptedAlchemy added 3 commits September 28, 2024 19:14

Merge branch 'main' into nx-upgrade

f810b5d

# Conflicts: # packages/chrome-devtools/package.json # pnpm-lock.yaml

chore: locks

8f59b24

chore: locks

c313095

ScriptedAlchemy merged commit 0a1b880 into main Sep 29, 2024
17 checks passed

ScriptedAlchemy deleted the nx-upgrade branch September 29, 2024 02:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update NX libraries to v19 #2764

chore: update NX libraries to v19 #2764

ScriptedAlchemy commented Jul 17, 2024 •

edited

Loading

changeset-bot bot commented Jul 17, 2024 •

edited

Loading

netlify bot commented Jul 17, 2024 •

edited

Loading

squadronai bot left a comment •

edited

Loading

squadronai bot left a comment

squadronai bot Sep 25, 2024

squadronai bot Sep 25, 2024

squadronai bot left a comment

squadronai bot Sep 25, 2024

squadronai bot left a comment

squadronai bot Sep 29, 2024

		//@ts-ignore
		vm.constants?.USE_MAIN_CONTEXT_DEFAULT_LOADER ?? importNodeModule,

chore: update NX libraries to v19 #2764

chore: update NX libraries to v19 #2764

Conversation

ScriptedAlchemy commented Jul 17, 2024 • edited Loading

Description

Related Issue

Types of changes

Checklist

changeset-bot bot commented Jul 17, 2024 • edited Loading

⚠️ No Changeset found

netlify bot commented Jul 17, 2024 • edited Loading

✅ Deploy Preview for module-federation-docs ready!

squadronai bot left a comment • edited Loading

Choose a reason for hiding this comment

Summary

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot Sep 25, 2024

Choose a reason for hiding this comment

squadronai bot Sep 25, 2024

Choose a reason for hiding this comment

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot Sep 25, 2024

Choose a reason for hiding this comment

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot Sep 29, 2024

Choose a reason for hiding this comment

ScriptedAlchemy commented Jul 17, 2024 •

edited

Loading

changeset-bot bot commented Jul 17, 2024 •

edited

Loading

netlify bot commented Jul 17, 2024 •

edited

Loading

squadronai bot left a comment •

edited

Loading