feat: support node esmodule and mf-manifest esmodule #2934

zhangHongEn · 2024-09-08T15:38:34Z

Description

Supports importing remote files in esm format in the node environment

Related Issue

module-federation/vite#73

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have added tests to cover my changes.
All new and existing tests passed.
I have updated the documentation.

changeset-bot · 2024-09-08T15:38:38Z

⚠️ No Changeset found

Latest commit: 24317ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2024-09-08T15:38:52Z

✅ Deploy Preview for module-federation-docs ready!

Name	Link
🔨 Latest commit	`24317ec`
🔍 Latest deploy log	https://app.netlify.com/sites/module-federation-docs/deploys/66f87b7537f5b600086319b6
😎 Deploy Preview	https://deploy-preview-2934--module-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

squadronai

Summary

This pull request adds support for importing remote files in ESM (ECMAScript Module) format in the Node.js environment. The key changes are as follows:

Update the moduleInfo object to handle the type property, which can now be set to 'esm' or 'global' depending on the remote module's format.
Introduce a new type property in the remoteInfo object, which is then passed to the loadScriptNode function to handle the different script types (CommonJS or ESM) and ensure proper loading of the remote entry.
Update the script type handling in the dom.ts file, adding the ability to set custom attributes on the created script element.
Modify the generateSnapshotFromManifest function to set the ssrRemoteEntryType property based on the type field of the ssrRemoteEntry object, allowing for both CommonJS and ESM formats.
Add a new loadModule function that handles the loading and evaluation of ESM modules, and update the createScriptNode function to support ESM scripts by leveraging the loadModule function.

These changes aim to improve the integration of the module federation library with the Node.js environment, allowing for the seamless handling of remote files in both CommonJS and ESM formats.

File Summaries

File	Summary
packages/runtime/src/plugins/generate-preload-assets.ts	The code changes introduce support for importing remote files in ESM format in the Node environment. This includes updating the `moduleInfo` object to handle the `type` property, which can now be set to `'esm'` or `'global'` depending on the remote module's format.
packages/runtime/src/utils/load.ts	The code changes introduce support for importing remote files in ESM format in the Node.js environment. The key modifications include adding a new `type` property to the `remoteInfo` object, which is then passed to the `loadScriptNode` function. This allows the function to handle the different script types (CommonJS or ESM) and ensure proper loading of the remote entry.
packages/sdk/src/dom.ts	The code changes introduce support for importing remote files in ESM format in the Node environment. The primary modifications include updating the script type based on the provided attributes, and adding the ability to set custom attributes on the created script element.
packages/sdk/src/generateSnapshotFromManifest.ts	The code changes introduce support for importing remote files in ESM format in the Node.js environment. The primary modification is to the `generateSnapshotFromManifest` function, where the `ssrRemoteEntryType` property is now set based on the `type` field of the `ssrRemoteEntry` object, allowing for both CommonJS and ESM formats.
packages/sdk/src/node.ts	The code changes introduce support for importing remote files in ESM format in the Node.js environment. The primary modifications include adding a new function `loadModule` that handles the loading and evaluation of ESM modules, and updating the `createScriptNode` function to support ESM scripts by leveraging the `loadModule` function.

squadronai

Incremental Review

Comments posted: 5

Configuration

Squadron Mode: essential

Commits Reviewed

760cc35c53dd9beb7ebba20b729108b2c61b0966...d9d4a22d7b269162675622e19bd675bd1357a3f8

Files Reviewed

packages/runtime/src/utils/load.ts
packages/sdk/src/generateSnapshotFromManifest.ts
packages/sdk/src/node.ts

squadronai

Incremental Review

Comments posted: 0

Configuration

Squadron Mode: essential

Commits Reviewed

d9d4a22d7b269162675622e19bd675bd1357a3f8...e60dabaca046ef623c926a245cd9377aa5fccb4f

Files Reviewed

packages/sdk/src/node.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json

squadronai

Incremental Review

Comments posted: 0

Configuration

Squadron Mode: essential

Commits Reviewed

e60dabaca046ef623c926a245cd9377aa5fccb4f...9cb92db6d1e2e16baa870402dccc7c05a1976379

Files Reviewed

packages/sdk/src/node.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json
packages/bridge/vue3-bridge/vite.config.ts.timestamp-1725810701228-7f307fef673c.mjs

…1228-7f307fef673c.mjs

ScriptedAlchemy · 2024-09-09T21:53:58Z

please run nx:format write

squadronai

Incremental Review

Comments posted: 0

Configuration

Squadron Mode: essential

Commits Reviewed

88214aa616d11842bdc16af3b4805310b064ffb9...d58b32713d1e038764fbdf00681741b4ed8813e4

Files Reviewed

packages/sdk/src/generateSnapshotFromManifest.ts
packages/sdk/src/node.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json

zhangHongEn · 2024-09-10T02:18:41Z

please run nx:format write

Thanks, it's now complete. I've run the fix on my home computer before, but it didn't take effect.

packages/sdk/src/node.ts

squadronai

Incremental Review

Comments posted: 3

Configuration

Squadron Mode: essential

Commits Reviewed

59758b7e0d6244a781cddf7e895743668164479c...14407ec24f82f99e20fe436c239d6de161b1e86b

Files Reviewed

packages/runtime/src/utils/load.ts
packages/sdk/src/generateSnapshotFromManifest.ts
packages/sdk/src/node.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json

squadronai

Incremental Review

Comments posted: 0

Configuration

Squadron Mode: essential

Commits Reviewed

59758b7e0d6244a781cddf7e895743668164479c...ef194a1236fb6717c2f1ba9e9516f102097445fb

Files Reviewed

packages/runtime/src/utils/load.ts
packages/sdk/src/generateSnapshotFromManifest.ts
packages/sdk/src/node.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json

squadronai

Incremental Review

Comments posted: 0

Configuration

Squadron Mode: essential

Commits Reviewed

caf4bd7c1eec9defb0ef8baba7bb9835b58a74db...a3e1bc5e9b94c2c3444bc19196e4bc3ebebf2847

Files Reviewed

packages/runtime/src/plugins/generate-preload-assets.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json

squadronai

Incremental Review

Comments posted: 6

Configuration

Squadron Mode: essential

Commits Reviewed

44ac346ef4212a17e4b2d611ba0e7948ba804947...dd254ef53f13419cdb9292cc3a35103d3cc0c2cc

Files Reviewed

packages/runtime/src/plugins/generate-preload-assets.ts
packages/runtime/src/utils/load.ts
packages/sdk/src/dom.ts
packages/sdk/src/generateSnapshotFromManifest.ts
packages/sdk/src/node.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json

squadronai · 2024-09-25T06:43:49Z

packages/runtime/src/plugins/generate-preload-assets.ts

@@ -328,7 +328,7 @@ export const generatePreloadAssetsPlugin: () => FederationRuntimePlugin =
                moduleInfo: {
                  name: remoteInfo.name,
                  entry: remote.entry,
-                  type: 'global',
+                  type: remoteInfo.type || 'global',


Consider providing a default value for the type property to ensure it always has a valid value, even if remoteInfo.type is undefined:

Suggested change

type: remoteInfo.type || 'global',

type: remoteInfo.type || 'global',

This change ensures that the type property will always have a value, defaulting to 'global' if remoteInfo.type is not provided. This can help prevent potential issues down the line if the code assumes type is always defined.

ScriptedAlchemy · 2024-09-26T22:07:47Z

packages/sdk/src/node.ts

+      TextEncoder,
+      console,
+      require: eval('require'),
+      __dirname,


bundler will transform these into strings in other targets, like browser etc. cant use short hand

Suggested change

__dirname,

__dirname: __dirname,

__filename: __filename,

ScriptedAlchemy · 2024-09-26T22:16:03Z

packages/sdk/src/node.ts

+  const code = await response.text();
+
+  const module: any = new vm.SourceTextModule(code, {
+    context,


I do not think you should pass a custom VM context to the module. Attempting to copy the global context does not work for many cases, there are many more primitives than just

Event, URL, URLSearchParams, TextDecoder, TextEncoder, console,

if you pass no context, then it will run in the current context and should operate like runInThisContext does for Script

squadronai

Incremental Review

Comments posted: 3

Configuration

Squadron Mode: essential

Commits Reviewed

2042777a4f2bfbb66d56f7cb08d94405dbe30048...7c2df68b4b924be1c8d19944687955915d047b2f

Files Reviewed

packages/runtime/src/plugins/generate-preload-assets.ts
packages/runtime/src/utils/load.ts
packages/sdk/src/dom.ts
packages/sdk/src/generateSnapshotFromManifest.ts
packages/sdk/src/node.ts

Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

package.json

ScriptedAlchemy · 2024-09-28T21:59:52Z

Moving to internal branch to help

ScriptedAlchemy · 2024-09-28T21:59:57Z

Moving to internal branch to help

Co-authored-by: zhn <zhang_h_n@163.com> Co-authored-by: 张洪恩 <zhanghongen@bwcj.com>

feat: support node esm

d9d4a22

github-actions bot added the change: feat label Sep 8, 2024

squadronai bot reviewed Sep 8, 2024

View reviewed changes

feat: add log

e60daba

squadronai bot reviewed Sep 8, 2024

View reviewed changes

feat: add try catch

9cb92db

squadronai bot reviewed Sep 8, 2024

View reviewed changes

Delete packages/bridge/vue3-bridge/vite.config.ts.timestamp-172581070…

88214aa

…1228-7f307fef673c.mjs

fix: format code

d58b327

squadronai bot reviewed Sep 10, 2024

View reviewed changes

ScriptedAlchemy reviewed Sep 10, 2024

View reviewed changes

packages/sdk/src/node.ts Outdated Show resolved Hide resolved

zhangHongEn mentioned this pull request Sep 10, 2024

ERROR [nitro] [unhandledRejection] A dynamic import callback was not specified. nuxt/nuxt#28911

Open

fix: Recovery Code

69d77aa

zhangHongEn force-pushed the feature/node-esm branch from f2ddef4 to 69d77aa Compare September 10, 2024 12:17

module-federation deleted a comment from squadronai bot Sep 10, 2024

Merge branch 'main' into feature/node-esm

14407ec

squadronai bot reviewed Sep 11, 2024

View reviewed changes

Merge branch 'main' into feature/node-esm

ef194a1

squadronai bot reviewed Sep 11, 2024

View reviewed changes

feat: mf-manifest.json module

5428a9a

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into feature/node-esm

30f33ea

module-federation deleted a comment from squadronai bot Sep 25, 2024

Merge branch 'main' into feature/node-esm

a3e1bc5

squadronai bot reviewed Sep 25, 2024

View reviewed changes

fix: node esm in webpack

dd254ef

squadronai bot reviewed Sep 25, 2024

View reviewed changes

zhangHongEn mentioned this pull request Sep 25, 2024

Question: Support for overriding chunk loading module-federation/vite#107

Open

module-federation deleted a comment from squadronai bot Sep 25, 2024

Merge branch 'main' into feature/node-esm

ff9228d

module-federation deleted a comment from squadronai bot Sep 26, 2024

ScriptedAlchemy reviewed Sep 26, 2024

View reviewed changes

ScriptedAlchemy and others added 2 commits September 27, 2024 15:02

Merge branch 'main' into feature/node-esm

6ba5b19

fix: node-esm context

7c2df68

squadronai bot reviewed Sep 28, 2024

View reviewed changes

zhangHongEn and others added 2 commits September 28, 2024 10:38

Merge branch 'main' into feature/node-esm

acc2f16

Merge branch 'main' into feature/node-esm

24317ec

module-federation deleted a comment from squadronai bot Sep 28, 2024

ScriptedAlchemy changed the base branch from main to feature/node-esm September 28, 2024 21:59

ScriptedAlchemy merged commit c529a72 into module-federation:feature/node-esm Sep 28, 2024
13 of 15 checks passed

ScriptedAlchemy added a commit that referenced this pull request Sep 29, 2024

feat: support node esmodule and mf-manifest esmodule (#2934) (#3013)

d018704

Co-authored-by: zhn <zhang_h_n@163.com> Co-authored-by: 张洪恩 <zhanghongen@bwcj.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support node esmodule and mf-manifest esmodule #2934

feat: support node esmodule and mf-manifest esmodule #2934

zhangHongEn commented Sep 8, 2024 •

edited

Loading

changeset-bot bot commented Sep 8, 2024 •

edited

Loading

netlify bot commented Sep 8, 2024 •

edited

Loading

squadronai bot left a comment •

edited

Loading

squadronai bot left a comment

squadronai bot left a comment

squadronai bot left a comment

ScriptedAlchemy commented Sep 9, 2024

squadronai bot left a comment

zhangHongEn commented Sep 10, 2024

squadronai bot left a comment

squadronai bot left a comment

This comment was marked as resolved.

squadronai bot left a comment

squadronai bot left a comment

squadronai bot Sep 25, 2024

ScriptedAlchemy Sep 26, 2024

ScriptedAlchemy Sep 26, 2024 •

edited

Loading

squadronai bot left a comment

ScriptedAlchemy commented Sep 28, 2024

ScriptedAlchemy commented Sep 28, 2024

	type: remoteInfo.type \|\| 'global',
	type: remoteInfo.type \|\| 'global',

feat: support node esmodule and mf-manifest esmodule #2934

feat: support node esmodule and mf-manifest esmodule #2934

Conversation

zhangHongEn commented Sep 8, 2024 • edited Loading

Description

Related Issue

Types of changes

Checklist

changeset-bot bot commented Sep 8, 2024 • edited Loading

⚠️ No Changeset found

netlify bot commented Sep 8, 2024 • edited Loading

✅ Deploy Preview for module-federation-docs ready!

squadronai bot left a comment • edited Loading

Choose a reason for hiding this comment

Summary

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

ScriptedAlchemy commented Sep 9, 2024

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

zhangHongEn commented Sep 10, 2024

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

This comment was marked as resolved.

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

squadronai bot Sep 25, 2024

Choose a reason for hiding this comment

ScriptedAlchemy Sep 26, 2024

Choose a reason for hiding this comment

ScriptedAlchemy Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

squadronai bot left a comment

Choose a reason for hiding this comment

Incremental Review

ScriptedAlchemy commented Sep 28, 2024

ScriptedAlchemy commented Sep 28, 2024

zhangHongEn commented Sep 8, 2024 •

edited

Loading

changeset-bot bot commented Sep 8, 2024 •

edited

Loading

netlify bot commented Sep 8, 2024 •

edited

Loading

squadronai bot left a comment •

edited

Loading

ScriptedAlchemy Sep 26, 2024 •

edited

Loading