fix(runtime): set loading if registeredShared not set #2943
Conversation
🦋 Changeset detectedLatest commit: 2fbd6cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This pull request introduces a fix to the runtime module's shared resource handling and a new type for the module federation plugin in the SDK. The key changes are:
- In the
SharedHandlerclass, theloadingflag is now set if theregisteredSharedproperty is not set. This ensures that the loading state is properly tracked for shared resources, which is important for managing their lifecycle in the runtime. - A new
'module-import'type has been added to theExternalsTypeunion in theModuleFederationPluginof the SDK. This change likely provides more flexibility and control over how external modules are loaded and resolved at runtime in a module federation setup.
These changes aim to improve the overall stability and functionality of the runtime and module federation features in the codebase.
File Summaries
| File | Summary |
|---|---|
| packages/runtime/src/shared/index.ts | The code changes introduce a fix to set the loading flag in the SharedHandler class if the registeredShared property is not set. This ensures that the loading state is properly tracked for shared resources, which is important for managing the lifecycle of these resources in the runtime. |
| packages/sdk/src/types/plugins/ModuleFederationPlugin.ts | The code changes introduce a new 'module-import' type to the ExternalsType union, which is used to specify the type of external dependencies in a module federation setup. This change likely aims to provide more flexibility and control over how external modules are loaded and resolved at runtime. |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 1
Configuration
Squadron Mode: essential
Commits Reviewed
2394e38a989077b87e42c48fbf4918dbb56b93fa...06a4f693f5e84fe62c24aeba43266e1c9adabd0a
Files Reviewed
- packages/runtime/src/shared/index.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/rude-trees-ring.md
| if (loading && !registeredShared.loading) { | ||
| registeredShared.loading = loading; | ||
| } |
There was a problem hiding this comment.
Consider updating the condition to set loading even if registeredShared.loading is already set. This ensures that the most up-to-date loading state is always reflected. Here's a suggested change:
| if (loading && !registeredShared.loading) { | |
| registeredShared.loading = loading; | |
| } | |
| if (loading) { | |
| registeredShared.loading = loading; | |
| } |
This modification allows the loading state to be updated even if it was previously set, which could be useful in scenarios where the loading state might change during the lifecycle of the shared module.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
06a4f693f5e84fe62c24aeba43266e1c9adabd0a...def2081d2a835d89676c8902c89d428b392dde6d
Files Reviewed
- packages/sdk/src/types/plugins/ModuleFederationPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/rude-trees-ring.md
- packages/storybook-addon/src/lib/storybook-addon.ts
Description
set loading if registeredShared not set
Related Issue
Types of changes
Checklist