Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modernjs): mfConfigPlugin should run after modernjs initial plugin #2947

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Sep 11, 2024

Description

mfConfigPlugin should run after @modern-js/plugin-initialize

Related Issue

@modern-js/plugin-initialize will inject bundlerType , so we must run our plugin after the initialize plugin has executed

https://github.com/web-infra-dev/modern.js/blob/main/packages/solutions/app-tools/src/plugins/initialize/index.ts#L44

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 1226017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@module-federation/modern-js Patch
modernjs-ssr-dynamic-nested-remote Patch
modernjs-ssr-dynamic-remote-new-version Patch
modernjs-ssr-dynamic-remote Patch
modernjs-ssr-host Patch
modernjs-ssr-nested-remote Patch
modernjs-ssr-remote-new-version Patch
modernjs-ssr-remote Patch
@module-federation/runtime Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
3008-runtime-remote Patch
host Patch
host-v5 Patch
host-vue3 Patch
remote1 Patch
remote2 Patch
remote3 Patch
remote4 Patch
@module-federation/modernjs Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 1226017
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66e16739655b07000849ee5c
😎 Deploy Preview https://deploy-preview-2947--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1 2heal1 changed the title fix(modernjs): mfConfigPlugin should run after @modern-js/plugin-init… fix(modernjs): mfConfigPlugin should run after modernjs initial plugin Sep 11, 2024
@zhoushaw zhoushaw merged commit 81201b8 into main Sep 11, 2024
23 checks passed
@zhoushaw zhoushaw deleted the fix/plugin-order branch September 11, 2024 10:02
@2heal1 2heal1 mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants