feat: adjust bridge router alias strategy #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d539f23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This pull request adjusts the bridge router alias strategy to handle different versions of the react-router-dom library. The primary goal is to ensure that the correct alias is used for the react-router-dom dependency, whether it's version 5 or version 6.
The key changes include:
- Added logic to determine the major version of the
react-router-domlibrary and set the appropriate alias accordingly. - If
react-router-domversion 6 is not found in the project'spackage.json, the alias will be set torouter-v6. - This change helps maintain compatibility and integration with the existing codebase, ensuring a seamless transition between different versions of the
react-router-domlibrary.
File Summaries
| File | Summary |
|---|---|
| packages/bridge/bridge-react-webpack-plugin/src/utis.ts | The code changes adjust the bridge router alias strategy to handle different versions of the react-router-dom library. The primary purpose is to ensure that the correct alias is used for the react-router-dom dependency, whether it's version 5 or version 6. The changes include logic to determine the major version of the react-router-dom library and set the appropriate alias accordingly. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 4
Configuration
Squadron Mode: essential
Commits Reviewed
4a79d27662c70232dac3dc5ee651dadb16d833be...d539f231cb691ebf02eb13bdbc1e2a7d483217c6
Files Reviewed
- packages/bridge/bridge-react-webpack-plugin/src/utis.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/fifty-kangaroos-compete.md
zhoushaw
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: adjust bridge router alias strategy to alias to router-v6 when not found react-router-dom in package.json.
Related Issue
Types of changes
Checklist