You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In /packages/dts-plugin/src/core/lib/typeScriptCompiler.ts:89, the regex already removes the .d.ts extension, so the expose path can be correctly mapped to an entry. Calling removeExt was further processing paths like foo.component to just foo, resulting in undefined being returned in getExposeKey.
I didn't check the testing checkbox because I encountered issues with some tests even before making the changes. I hope that, even if this PR doesn't meet the criteria for merging, it can at least serve as documentation for someone else to fix it.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I’ve requested your review again because I rebased the branch. Some tests that were failing in GitHub Actions were passing locally, which led me to believe the issue might be with the tests themselves. After noticing some recent commits related to the tests, I decided to rebase. Everything seems to be passing now.
artieeez
added a commit
to artieeez/module-federation-core
that referenced
this pull request
Sep 26, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
artieeez
force-pushed
the
fix/multiple-dots-files
branch
from
Description
In
/packages/dts-plugin/src/core/lib/typeScriptCompiler.ts:89, the regex already removes the.d.tsextension, so the expose path can be correctly mapped to an entry. Calling removeExt was further processing paths likefoo.componentto justfoo, resulting inundefinedbeing returned ingetExposeKey.I didn't check the testing checkbox because I encountered issues with some tests even before making the changes. I hope that, even if this PR doesn't meet the criteria for merging, it can at least serve as documentation for someone else to fix it.
Related Issue
#2957
Types of changes
Checklist