fix(enhanced): container addInclude wrap in make hook #3002
Conversation
🦋 Changeset detectedLatest commit: 040c7f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This pull request focuses on improving the handling of the addInclude operation in the ContainerPlugin and ensuring the proper setup of the FederationRuntimeDependency in the FederationRuntimePlugin. The changes are designed to address potential timing and execution issues related to the federation runtime dependency.
The key changes include:
- Wrapping the
addIncludeoperation in an asynchronousmakehook to ensure it is executed correctly within theContainerPlugin. - Introducing an additional check to ensure the
FederationRuntimeDependencyis properly set up before it is returned, by calling theensureFilemethod.
These improvements help to enhance the reliability and robustness of the federation runtime functionality within the enhanced package.
File Summaries
| File | Summary |
|---|---|
| packages/enhanced/src/lib/container/ContainerPlugin.ts | The code changes ensure that the addInclude operation is performed asynchronously within a make hook, which is necessary for the proper handling of the federation runtime dependency. This change helps to address potential issues related to the timing and execution of the addInclude operation. |
| packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts | The code changes introduce an additional check to ensure that the FederationRuntimeDependency is properly set up before it is returned. This is done by calling the ensureFile method, which likely sets up the necessary file dependencies for the FederationRuntimeDependency. This change helps to ensure the correct initialization of the FederationRuntimeDependency object, which is a crucial part of the federation runtime plugin. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 3
Configuration
Squadron Mode: essential
Commits Reviewed
39bfbb444516cec371636e59b9d262b35a603d50...d23e786fc58b6811234865ba98a20bc567820ae6
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-hungry-tiger.md
There was a problem hiding this comment.
Incremental Review
Comments posted: 3
Configuration
Squadron Mode: essential
Commits Reviewed
d23e786fc58b6811234865ba98a20bc567820ae6...43757c8bf75c78fa4c3ab0bb6f6e8c56f4928732
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-hungry-tiger.md
There was a problem hiding this comment.
Incremental Review
Comments posted: 5
Configuration
Squadron Mode: essential
Commits Reviewed
43757c8bf75c78fa4c3ab0bb6f6e8c56f4928732...52e009571de88a0991983913476c6b09f3392cd0
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-hungry-tiger.md
- packages/enhanced/project.json
ScriptedAlchemy
force-pushed
the
add-include-container
branch
from
a2f053b
to
a7616db
Compare
There was a problem hiding this comment.
Incremental Review
Comments posted: 4
Configuration
Squadron Mode: essential
Commits Reviewed
52e009571de88a0991983913476c6b09f3392cd0...a7616db0994086ee40973dc6cdcccc9505593d8f
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-hungry-tiger.md
- ai-lint-fix.js
- packages/enhanced/project.json
- packages/enhanced/test/ConfigTestCases.template.js
There was a problem hiding this comment.
Incremental Review
Comments posted: 2
Configuration
Squadron Mode: essential
Commits Reviewed
a7616db0994086ee40973dc6cdcccc9505593d8f...040c7f685de69a5825a042cb0ac404be3cc5f037
Files Reviewed
- packages/enhanced/src/lib/container/ContainerPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/ai-hungry-tiger.md
- ai-lint-fix.js
- packages/enhanced/project.json
- packages/enhanced/test/ConfigTestCases.template.js
Description
Ensure addInclude is done so in a async hook
Related Issue
Types of changes
Checklist