fix(runtime): catch init remote error in errorLoadRemote hook #3019
Conversation
🦋 Changeset detectedLatest commit: 7f790e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This pull request introduces changes to the runtime module of the application to improve error handling when loading remote modules. The key changes are:
- Added a new
'beforeLoadShare'lifecycle event to theRemoteHandlerclass to catch and handle errors that may occur during the initialization of a remote module. - Wrapped the call to
module.getEntry()in theSharedHandlerclass with a try-catch block to catch any errors and emit anerrorLoadRemoteevent in case of an error.
These changes aim to enhance the robustness and reliability of the remote module loading process by providing more comprehensive error handling and reporting. The updates ensure that the application can gracefully handle and recover from errors that may occur during the initialization of remote modules, improving the overall user experience.
File Summaries
| File | Summary |
|---|---|
| packages/runtime/src/remote/index.ts | The code changes introduce a new error handling case in the errorLoadRemote hook of the RemoteHandler class. Specifically, it adds a new 'beforeLoadShare' lifecycle event to handle errors that may occur during the initialization of a remote module. |
| packages/runtime/src/shared/index.ts | The code changes introduce a try-catch block around the call to module.getEntry() in the SharedHandler class. This is done to catch any errors that may occur during the initialization of a remote module, and to emit a errorLoadRemote event in the event of an error. The purpose of this change is to improve the error handling and robustness of the remote module loading process. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 1
Configuration
Squadron Mode: essential
Commits Reviewed
15f9de1ae9a11a06ed1af8556b14b83ce57fb3a4...7f790e42e3300eae6df481e03a6f5dd1fb0f47ff
Files Reviewed
- packages/runtime/src/remote/index.ts
- packages/runtime/src/shared/index.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/nervous-tomatoes-raise.md
Description
catch init remote error in errorLoadRemote hook
Related Issue
Types of changes
Checklist