New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manifest publicPath #91

Merged

gioboa merged 2 commits into module-federation:main from zhangHongEn:main

Sep 18, 2024

Contributor

zhangHongEn commented Sep 18, 2024

No description provided.

张洪恩 added 2 commits

September 18, 2024 20:05


          fix: manifest publicPath

848f0a9


          fix: manifest publicPath

d24902d

gioboa approved these changes

View reviewed changes

Collaborator

gioboa left a comment

LGTM @zhangHongEn

Collaborator

gioboa commented Sep 18, 2024

why the lib folder is versioned?
I'll remove it. @zhangHongEn do you have any concerns?

Contributor Author

zhangHongEn commented Sep 18, 2024 via email

Deleting it will result in an error when installing pnpm, which is not very friendly to examples

---- Replied Message ---- | From | Giorgio ***@***.***> | | Date | 09/18/2024 20:44 | | To | module-federation/vite ***@***.***> | | Cc | zhn ***@***.***>, Mention ***@***.***> | | Subject | Re: [module-federation/vite] fix: manifest publicPath (PR #91) | @gioboa approved this pull request. LGTM @zhangHongEn — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Contributor Author

zhangHongEn commented Sep 18, 2024 via email

I have no objections to deleting it

---- Replied Message ---- | From | Giorgio ***@***.***> | | Date | 09/18/2024 20:44 | | To | module-federation/vite ***@***.***> | | Cc | zhn ***@***.***>, Mention ***@***.***> | | Subject | Re: [module-federation/vite] fix: manifest publicPath (PR #91) | @gioboa approved this pull request. LGTM @zhangHongEn — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Collaborator

gioboa commented Sep 18, 2024

Deleting it will result in an error when installing pnpm, which is not very friendly to examples

I'll force a build before the pnpm install

gioboa merged commit b246f36 into module-federation:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet