Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce an error that should fail unit tests #1

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Introduce an error that should fail unit tests #1

merged 3 commits into from
Nov 20, 2023

Conversation

mofojed
Copy link
Owner

@mofojed mofojed commented Nov 20, 2023

No description provided.

@github-actions GitHub Actions
Copy link

Pull Request titles must follow the Conventional Commits specification.

Details:

No release type found in pull request title "Introduce an error that should fail unit tests". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@mofojed mofojed merged commit a8a41ec into main Nov 20, 2023
2 of 3 checks passed
mofojed pushed a commit that referenced this pull request Nov 6, 2024
@jnumainville
feat: Allow passing in a pandas dataframe to dx plots (deephaven#967)
cf03ff0 
Fixes #8 

Allows passing in a pandas dataframe to all plots that take a table.

Example:
```import plotly.express as px
import deephaven.plot.express as dx
df = px.data.iris()
fig = dx.scatter(df, x="sepal_width", y="sepal_length", color="species", symbol="species")
```

Also now require a table (or similar) passed in for all plot types, as
is already done for `density_heatmap`. This was part of #1, although not
the full changes needed, but made sense to do now. This doesn't break
anything as the plot isn't expected to work without a table anyways.

Additionally adds a test utility for chart comparisons. Not so essential
that all tests need to change per se but reduces future test
boilerplate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mofojed