Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom reload action for Browser Action #20

Closed
mohamedmansour opened this issue Dec 3, 2018 · 2 comments · Fixed by #36
Closed

Allow custom reload action for Browser Action #20

mohamedmansour opened this issue Dec 3, 2018 · 2 comments · Fixed by #36
Labels
feature request good first issue Great First Bug to contribute!
Milestone
v5.0.0

Comments

@mohamedmansour
Copy link
Owner

Currently the reload strategy of the browser action is either all windows or current window. It would be nice to extend it so the user can customize it.

/**
 * Reload Routine. It checks which option the user has allowed (All windows, or
 * or just the current window) then initiates the request.
 */
ReloadController.prototype.reload = function(info, tab)
{
  if (this.cachedSettings.reloadAllWindows) { // All Windows.
    this.reloadAllWindows()
  }
  else { // Current Window.
    chrome.windows.getCurrent(this.reloadWindow.bind(this))
  }
}
@mohamedmansour
Copy link
Owner Author

Actually, its a bug, reloadAllWindows doesn't pass the options

@mohamedmansour mohamedmansour mentioned this issue Feb 1, 2019
Open
@equalsJeffH equalsJeffH mentioned this issue Feb 10, 2020
Closed
@mohamedmansour
Copy link
Owner Author

mohamedmansour commented May 3, 2021 •
edited
Loading

This is implemented in #32 !

@mohamedmansour mohamedmansour mentioned this issue May 3, 2021
Closed
@mohamedmansour mohamedmansour added the good first issue Great First Bug to contribute! label May 3, 2021
@mohamedmansour mohamedmansour added this to the v5.0.0 milestone May 3, 2021
@mohamedmansour mohamedmansour mentioned this issue May 4, 2021
Merged
mohamedmansour added a commit that referenced this issue May 4, 2021
@sniemetz @mohamedmansour
Add ability to customize the browser_action (#36)
5f3093a 
In options set the action for a click on the menu icon (browser_action)

Fixes #20

Co-authored-by: Mohamed Mansour <hello@mohamedmansour.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue Great First Bug to contribute!
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

Add ability to customize the browser_action
add close tabs left/right
1 participant
@mohamedmansour