-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert isMouseOutside changes in favor of mouseleave event listener #127
Conversation
@czabaj @mohsinulhaq please take a look, I'll update tests and readme later. I also think we should add an idea from #126 as an example to our examples section. Maybe we should introduce the layout/offset feature as the next major update. I still think removing the offset option and move the offset completely to CSS is a better DX than we have now. Also, it helps in interactive mode. |
@czabaj I'm really sorry about removing a huge chunk of code you have written. It was a good experience anyway. |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 94.01% 91.17% -2.84%
==========================================
Files 2 2
Lines 167 136 -31
Branches 56 41 -15
==========================================
- Hits 157 124 -33
- Misses 10 12 +2
Continue to review full report at Codecov.
|
@denisborovikov well, nobody likes bugs anyway - I'm open to the more bulletproof solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
And because of the pointer-events: none
, we don't even need to revert back to [0, 7] offset anymore.
I've updated the READMe and added a new attribute description. I think we can release this as non-breaking. |
Hi @denisborovikov ! |
@yomansk8 please check out |
The PR is an attempt to fix some edge-case bugs introduced after replacing mouseleave event listener with custom mouse outside position calculations.
Some thoughts are in discussion #126
The final fix doesn't change the layout of the tooltip in order to avoid breaking changes.
mouseleave
listener reverted,isMouseOutside
removeddata-popper-interactive="true"
is used to setpointer-events: none
to the tooltippointer-events: none
applied by default to the arrow element