Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade versions in setup.py #1336

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

UlrichB22
Copy link
Collaborator

Change dependencies to upgrade to newer versions as discussed in #1109

  • Flask 2.0.3
  • Flask-Script 2.0.5
  • Jinja2 3.0.3
  • MarkupSafe 2.1.2
  • Werkzeug 2.1.2

Hopefully it also fixes #1333, my tests with ./m docs run successfully in Debian 11.

Please support with testing in different environments.

@RogerHaase RogerHaase merged commit c82ed6a into moinwiki:master Jan 19, 2023
@RogerHaase
Copy link
Member

Works on Windows 10 with Python 3.10. But a freshly created venv still has sphinx-rtd-theme version 0.5.1 even though docs/requirements says "sphinx-rtd-theme==1.1.1".

Still fails on readthedocs with "sphinx-rtd-theme==1.1.1 ". See readthedocs/sphinx_rtd_theme#1323

"""
python -m pip install --exists-action=w --no-cache-dir -r docs/requirements.txt
Collecting docutils>=0.18.1
Downloading docutils-0.19-py3-none-any.whl (570 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 570.5/570.5 kB 44.3 MB/s eta 0:00:00
Collecting sphinx>=5.3.0
Downloading sphinx-6.1.3-py3-none-any.whl (3.0 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.0/3.0 MB 122.4 MB/s eta 0:00:00
Collecting sphinx-rtd-theme==1.1.1
Downloading sphinx_rtd_theme-1.1.1-py2.py3-none-any.whl (2.8 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.8/2.8 MB 217.5 MB/s eta 0:00:00
Collecting sphinx>=5.3.0
Downloading sphinx-5.3.0-py3-none-any.whl (3.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.2/3.2 MB 229.5 MB/s eta 0:00:00
ERROR: Cannot install -r docs/requirements.txt (line 4) and docutils>=0.18.1 because these package versions have conflicting dependencies.

The conflict is caused by:
The user requested docutils>=0.18.1
sphinx-rtd-theme 1.1.1 depends on docutils<0.18

To fix this you could try to:

  1. loosen the range of package versions you've specified
  2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
"""

Upgrading sphinx to 1.1.1 fails. Upgrading sphinx-rtd-theme to 1.2.0rc3 Succeeds,

@UlrichB22
Copy link
Collaborator Author

Is it ok to temporarily pin sphinx-rtd-theme to 1.2.0rc3 in requirements.txt?
Version 1.2.0 seems to be coming soon.

@RogerHaase
Copy link
Member

Yes, but installing sphinx-rtd-theme to 1.2.0rc3 still downgrades docutils to 18.1.

I am thinking it is time to find another theme. The theme was changed from classic to sphinx-rtd-theme on 2016-02-03: cf48fcc because it had better support for smartphone screen sizes.

@UlrichB22 UlrichB22 deleted the upgr_setup branch January 20, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadTheDocs build failed
2 participants