Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate metric source field #437

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Conversation

EduardZaydler
Copy link
Member

@EduardZaydler EduardZaydler commented Oct 2, 2023

displaced metric source selection field before target input field
separated the source selection field into a separate component
updated screens due to unstable creevey, should be working with new dependancies
image

@EduardZaydler EduardZaydler requested a review from a team as a code owner October 2, 2023 04:25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

О, в предыдущем МРе здесь календарь начинался с июня, а теперь починилось.

sol-un
sol-un previously approved these changes Oct 2, 2023
FonDumik
FonDumik previously approved these changes Oct 2, 2023
GreoGi
GreoGi previously approved these changes Oct 2, 2023
@EduardZaydler EduardZaydler dismissed stale reviews from GreoGi, FonDumik, and sol-un via 9703d0c October 6, 2023 05:00
@EduardZaydler
Copy link
Member Author

/build

<Radio value={TriggerSource.GRAPHITE_LOCAL}> Local (default)</Radio>
<Radio value={TriggerSource.GRAPHITE_REMOTE}>
Graphite Remote. Be careful, it may cause{" "}
<Link href="http://moira.readthedocs.io/en/latest/user_guide/advanced.html#data-source">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ссылку бы в константу убрать

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ок, сделал

@EduardZaydler
Copy link
Member Author

/build

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Build and push Docker images with tag: 2023-10-06.966a9e6

@EduardZaydler EduardZaydler merged commit 966a9e6 into master Oct 6, 2023
2 checks passed
@EduardZaydler EduardZaydler deleted the fix/relocate_metric_source branch October 6, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants