Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Vue-2 to Vue-3 for FLINT-UI #294

Merged
merged 15 commits into from
Jun 6, 2022
Merged

Migrate Vue-2 to Vue-3 for FLINT-UI #294

merged 15 commits into from
Jun 6, 2022

Conversation

HarshCasper
Copy link
Member

@vercel
Copy link

vercel bot commented Jun 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flint-ui ✅ Ready (Inspect) Visit Preview Jun 6, 2022 at 2:19PM (UTC)

@YashKandalkar
chore: upgrade all libraries, remove unnecessary libraries, fix error…
736cc55 
…s during migration

Signed-off-by: YashKandalkar <yashsk.yk@gmail.com>
@HarshCasper HarshCasper requested a review from Palaksharma23 June 4, 2022 12:55
@Crystalsage
fix+refactor: convert StepperGCBM to Ant Design (#295)
aee55e6 
Converts `StepperGCBM` from the Material Vue based component
to an Ant Design based one. Now we can switch between GCBM
pages in Vue3. Also fixes social icon hover bug and a typo.

Signed-off-by: Amit <amitkulkarni2028@gmail.com>
@Palaksharma23
Copy link
Member

image

Little UI issues are there in GCBM and GCBM is not working fine.

@SanjaySinghRajpoot
Copy link
Collaborator

image

Little UI issues are there in GCBM and GCBM is not working fine.

Yes, I am having the same issue as above. Moreover, I am unable to see the toggle button below the GCBM heading. I don't know whether I am only facing this issue or if it's with everyone. Along with I got some warnings with :v-deep tag used in the slider component when I first compiled the code. Later they disappeared from the terminal after 2-3 compile reloads

Have a look at this for the above warning https://stackoverflow.com/questions/48032006/how-do-i-use-deep-or-or-v-deep-in-vue-js

Else the changes look to me.

@Janvi-Thakkar
Copy link
Collaborator

image
Little UI issues are there in GCBM and GCBM is not working fine.

Yes, I am having the same issue as above. Moreover, I am unable to see the toggle button below the GCBM heading. I don't know whether I am only facing this issue or if it's with everyone. Along with I got some warnings with :v-deep tag used in the slider component when I first compiled the code. Later they disappeared from the terminal after 2-3 compile reloads

Have a look at this for the above warning https://stackoverflow.com/questions/48032006/how-do-i-use-deep-or-or-v-deep-in-vue-js

Else the changes look to me.

I am not even able to see the toggle button neither on the deployed link nor on my local machine.

sohamsshah
sohamsshah requested changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@sohamsshah sohamsshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @YashKandalkar ! 👏
Have requested a few minor changes, please incorporate them.

Thanks for the PR!

flint.ui/src/components/FileUpload/FileUpload.vue Outdated Show resolved Hide resolved
flint.ui/src/components/FileUpload/FileUpload.vue Outdated Show resolved Hide resolved
flint.ui/src/components/Stepper/StepperGCBM.vue Outdated Show resolved Hide resolved
@YashKandalkar
Copy link
Collaborator

@Palaksharma23 @Janvi-Thakkar @SanjaySinghRajpoot @sohamsshah Thanks for the review! I have made the requested changes, PTAL

@Janvi-Thakkar
Copy link
Collaborator

@Palaksharma23 @Janvi-Thakkar @SanjaySinghRajpoot @sohamsshah Thanks for the review! I have made the requested changes, PTAL

Great work @YashKandalkar :) The toggle button is still not visible on deployed preview in my machine not sure whether it is only happening with me or if anyone else has the same issue

@YashKandalkar
Copy link
Collaborator

@Janvi-Thakkar The Toggle button only comes on the last step (Run).

@HarshCasper HarshCasper merged commit 51f34b0 into master Jun 6, 2022
@HarshCasper HarshCasper deleted the vue-3-migration branch June 6, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohamsshah sohamsshah sohamsshah requested changes

@YashKandalkar YashKandalkar Awaiting requested review from YashKandalkar

@aornugent aornugent Awaiting requested review from aornugent

@shubhamkarande13 shubhamkarande13 Awaiting requested review from shubhamkarande13

@shloka-gupta shloka-gupta Awaiting requested review from shloka-gupta

@SanjaySinghRajpoot SanjaySinghRajpoot Awaiting requested review from SanjaySinghRajpoot

@Palaksharma23 Palaksharma23 Awaiting requested review from Palaksharma23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HarshCasper @Palaksharma23 @SanjaySinghRajpoot @Janvi-Thakkar @YashKandalkar @sohamsshah @Crystalsage