Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2092)!: prefixes for api definitions and upgraded node version #138

Merged
merged 33 commits into from
Jul 28, 2022

Conversation

vijayg10
Copy link
Collaborator

@vijayg10 vijayg10 commented Jul 19, 2022

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092

  • Upgrade to node v16
  • Update packages/linting/audit/dockerfile
  • Update ci with dep/audit checks
  • Installed pre-commit hooks
  • feat:added options to api management page

Notes:

  • Helm chart mountPaths need to be updated from /opt/mojaloop-testing-toolkit-ui to /opt/app as follows:
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/mojaloop-testing-toolkit-ui which will impact config mounts.

Major version bump since this is a big upgrade.

@vijayg10 vijayg10 self-assigned this Jul 19, 2022
@vijayg10 vijayg10 marked this pull request as ready for review July 19, 2022 16:44
@elnyry-sam-k elnyry-sam-k changed the title feat: implemented prefixes for api definitions and upgraded node version feat!: prefixes for api definitions and upgraded node version Jul 19, 2022
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please some comments.

In addition:

Take note that you should create a snapshot for testing on the OSS environment before any merges are done here, example PR where this is done: mojaloop/als-oracle-pathfinder#72

.eslintrc Show resolved Hide resolved
.ncurc.yaml Show resolved Hide resolved
.ncurc.yaml Outdated Show resolved Hide resolved
audit-ci.jsonc Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
vijayg10 and others added 6 commits July 20, 2022 17:46
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Co-authored-by: Miguel de Barros <miguel@debarros.me>
BREAKING CHANGE: upgraded node version to v16
@vijayg10 vijayg10 requested a review from mdebarros July 20, 2022 12:27
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vijayg10,

One minor comment left for you to address.

README.md Outdated Show resolved Hide resolved
@mdebarros
Copy link
Member

@vijayg10 I also updated your PR description, please take note of it, and ensure that you include the PR description as part of your merge commit message.

We need to be specific about what is breaking! Node upgrade is nice, but the real breaking change here is the dockerfile working directory that needs to be explicitly called out. Unless there is something else that you are aware of that needs to be added.

@vijayg10 vijayg10 requested a review from mdebarros July 21, 2022 09:15
@mdebarros mdebarros changed the title feat!: prefixes for api definitions and upgraded node version feat(mojaloop/#2092)!: prefixes for api definitions and upgraded node version Jul 21, 2022
@mdebarros
Copy link
Member

I further update the PR description. See the changes above.

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vijayg10 vijayg10 merged commit 64e9fb7 into mojaloop:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants