Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2802): rework ProcessBulkQuotesCallback logic and add int tests for bulk quotes #366

Merged
merged 25 commits into from
Sep 15, 2022
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions modules/api-svc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
},
"dependencies": {
"@koa/cors": "^3.4.1",
"@mojaloop/api-snippets": "^15.0.0",
"@mojaloop/api-snippets": "^15.0.1",
"@mojaloop/central-services-error-handling": "^12.0.4",
"@mojaloop/central-services-logger": "^11.0.1",
"@mojaloop/central-services-metrics": "^12.0.5",
Expand Down Expand Up @@ -95,16 +95,16 @@
"@babel/core": "^7.19.0",
"@babel/preset-env": "^7.19.0",
"@redocly/openapi-cli": "^1.0.0-beta.94",
"@types/jest": "^29.0.0",
"babel-jest": "^29.0.2",
"eslint": "^8.23.0",
"@types/jest": "^29.0.1",
"babel-jest": "^29.0.3",
"eslint": "^8.23.1",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jest": "^27.0.2",
"jest": "^29.0.2",
"eslint-plugin-jest": "^27.0.4",
"jest": "^29.0.3",
"jest-junit": "^14.0.1",
"nock": "^13.2.9",
"npm-check-updates": "^16.1.0",
"npm-check-updates": "^16.1.2",
"openapi-response-validator": "^12.0.2",
"openapi-typescript": "^5.4.1",
"redis-mock": "^0.56.3",
Expand Down
103 changes: 0 additions & 103 deletions modules/api-svc/src/InboundServer/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1779,53 +1779,6 @@ paths:
$ref: '#/components/responses/501'
'503':
$ref: '#/components/responses/503'
/bulkQuotes:
post:
description: >-
The HTTP request `POST /bulkQuotes` is used to request the creation of a
bulk quote for the provided financial transactions in the server.
summary: Calculate bulk quote
tags:
- bulkQuotes
operationId: BulkQuotes
parameters:
- $ref: '#/components/parameters/Accept'
- $ref: '#/components/parameters/Content-Length'
- $ref: '#/components/parameters/Content-Type'
- $ref: '#/components/parameters/Date'
- $ref: '#/components/parameters/X-Forwarded-For'
- $ref: '#/components/parameters/FSPIOP-Source'
- $ref: '#/components/parameters/FSPIOP-Destination'
- $ref: '#/components/parameters/FSPIOP-Encryption'
- $ref: '#/components/parameters/FSPIOP-Signature'
- $ref: '#/components/parameters/FSPIOP-URI'
- $ref: '#/components/parameters/FSPIOP-HTTP-Method'
requestBody:
description: Details of the bulk quote to be created.
required: true
content:
application/json:
schema:
$ref: '#/components/schemas/BulkQuotesPostRequest'
responses:
'202':
$ref: '#/components/responses/202'
'400':
$ref: '#/components/responses/400'
'401':
$ref: '#/components/responses/401'
'403':
$ref: '#/components/responses/403'
'404':
$ref: '#/components/responses/404'
'405':
$ref: '#/components/responses/405'
'406':
$ref: '#/components/responses/406'
'501':
$ref: '#/components/responses/501'
'503':
$ref: '#/components/responses/503'
/bulkQuotes/{ID}:
parameters:
- $ref: '#/components/parameters/ID'
Expand Down Expand Up @@ -3372,62 +3325,6 @@ components:
$ref: '#/components/schemas/ExtensionList'
required:
- transactionState
IndividualQuote:
title: IndividualQuote
type: object
description: Data model for the complex type IndividualQuote.
properties:
quoteId:
$ref: '#/components/schemas/CorrelationId'
transactionId:
$ref: '#/components/schemas/CorrelationId'
payee:
$ref: '#/components/schemas/Party'
amountType:
$ref: '#/components/schemas/AmountType'
amount:
$ref: '#/components/schemas/Money'
fees:
$ref: '#/components/schemas/Money'
transactionType:
$ref: '#/components/schemas/TransactionType'
note:
$ref: '#/components/schemas/Note'
extensionList:
$ref: '#/components/schemas/ExtensionList'
required:
- quoteId
- transactionId
- payee
- amountType
- amount
- transactionType
BulkQuotesPostRequest:
title: BulkQuotesPostRequest
type: object
description: The object sent in the POST /bulkQuotes request.
properties:
bulkQuoteId:
$ref: '#/components/schemas/CorrelationId'
payer:
$ref: '#/components/schemas/Party'
geoCode:
$ref: '#/components/schemas/GeoCode'
expiration:
$ref: '#/components/schemas/DateTime'
individualQuotes:
type: array
minItems: 1
maxItems: 1000
items:
$ref: '#/components/schemas/IndividualQuote'
description: List of quotes elements.
extensionList:
$ref: '#/components/schemas/ExtensionList'
required:
- bulkQuoteId
- payer
- individualQuotes
IndividualQuoteResult:
title: IndividualQuoteResult
type: object
Expand Down
16 changes: 8 additions & 8 deletions modules/outbound-command-event-handler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"snapshot": "standard-version --no-verify --skip.changelog --prerelease snapshot --releaseCommitMessageFormat 'chore(snapshot): {{currentTag}}'"
},
"dependencies": {
"@mojaloop/api-snippets": "^15.0.0",
"@mojaloop/api-snippets": "^15.0.1",
"@mojaloop/logging-bc-client-lib": "^0.1.13",
"@mojaloop/logging-bc-public-types-lib": "^0.1.10",
"@mojaloop/sdk-scheme-adapter-private-shared-lib": "workspace:^",
Expand All @@ -54,19 +54,19 @@
"devDependencies": {
"@types/convict": "^6.1.1",
"@types/express": "^4.17.13",
"@types/jest": "^29.0.0",
"@types/node": "^18.7.16",
"@types/jest": "^29.0.1",
"@types/node": "^18.7.17",
"@types/node-cache": "^4.2.5",
"@types/supertest": "^2.0.12",
"@types/swagger-ui-express": "^4.1.3",
"@types/yamljs": "^0.2.31",
"@typescript-eslint/eslint-plugin": "^5.36.2",
"@typescript-eslint/parser": "^5.36.2",
"@typescript-eslint/eslint-plugin": "^5.37.0",
"@typescript-eslint/parser": "^5.37.0",
"copyfiles": "^2.4.1",
"eslint": "^8.23.0",
"jest": "^29.0.2",
"eslint": "^8.23.1",
"jest": "^29.0.3",
"nodemon": "^2.0.19",
"npm-check-updates": "^16.1.0",
"npm-check-updates": "^16.1.2",
"replace": "^1.2.1",
"standard-version": "^9.5.0",
"ts-jest": "^29.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import * as ProcessSDKOutboundBulkPartyInfoRequestHandler from './process_sdk_ou
import * as ProcessSDKOutboundBulkPartyInfoRequestCompleteHandler from './process_sdk_outbound_bulk_party_info_request_complete';
import * as ProcessPartyInfoCallbackHandler from './process_party_info_callback';
import * as ProcessSDKOutboundBulkAcceptPartyInfoHandler from './process_sdk_outbound_bulk_accept_party_info';
import * as ProcessBulkQuotesCallbackHandler from './process-bulk-quotes-callback';
import * as ProcessBulkQuotesCallbackHandler from './process_bulk_quotes_callback';
import * as ProcessSDKOutboundBulkQuotesRequestHandler from './process_sdk_outbound_bulk_quotes_request';

import { CommandEvent } from '@mojaloop/sdk-scheme-adapter-private-shared-lib';
Expand Down
Loading