Add strict option to EnforceBytecodeVersion to not ignore module-info and Multi-Release JAR classes #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow Maven code style for xml |
Updated. Please note that many of the existing integration test pom.xml files do not follow Maven code style. |
I know, but new files can be better ... thanks. last request - please squash to one final commit. |
… and Multi-Release JAR classes
Mooninaut
force-pushed
the
strict-bytecode-version
branch
from
e2ade9d to
58cc452
Compare
Done! |
slachiewicz
approved these changes
Jun 7, 2022
|
@Mooninaut thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to deploy a web application to a servlet container that bundles an obsolete version of ASM, which throws an exception when it encounters any Java 9+ class files. Even a harmless
module-info.classin a dependency causes the deployment to fail. I would like to use the enforceByteCodeVersion rule to prevent breaking the app, but currently the rule automatically ignores module-info.class and Multi-Release JAR classes.This PR adds:
strictoption to theenforceBytecodeVersionrule that causes the rule to fail when amodule-info.classand / or Multi-Release JAR class with a prohibited bytecode version is detectedstrictoptionstrictoption