Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #291 Use scope/optional of profile dep over default #296

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

andpab
Copy link
Contributor

@andpab andpab commented Aug 6, 2022

No description provided.

@slawekjaranowski
Copy link
Member

Please squash to one final commit

If the scope/optional for a dependency with an entry in dependency
management is explicitly defined in a profile dependency but not in the
dependency management section, then use the scope/optional defined in
the profile dependency rather than falling back to the default value
@andpab
Copy link
Contributor Author

andpab commented Aug 8, 2022

squashed it. check again please.

@slawekjaranowski slawekjaranowski merged commit 374abca into mojohaus:master Aug 8, 2022
@andpab andpab deleted the fix-issue-291 branch August 10, 2022 13:02
@slawekjaranowski slawekjaranowski changed the title Fix issue #291 Use scope/optional of profile dep over default Fix #291 Use scope/optional of profile dep over default Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope/optional of profile dependency is ignored if version managed in dependency management
2 participants