Make check mojo thread-safe: #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It operates on the POM file of the current module only, hence other modules that might being built in parallel, cannot affect it. Also add missing `@Override` annotation. Resolves mojohaus#27
Stephan202
approved these changes
Jun 20, 2019
|
Hi, could anyone, please, review the patch, and, if it is OK, release it? Currently running this mojo results in lots of false-positive warnings, which might make the developers blind to the actual warnings. |
|
@stefanbirkner are you (still) a maintainer of this repository? A release with this PR and the changes of #15 would be great 🙂 |
|
@stefanbirkner, I'd also appreciate a new release with that fix included. |
|
Any chance to have new release, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mojo operates on the POM file of the current module only, hence
other modules that might being built in parallel, cannot affect it.
Also add missing
@Overrideannotation.Resolves #27