Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for xinclude in transformation and validation #13

Merged
merged 1 commit into from
May 7, 2017
Merged

Conversation

G-Ork
Copy link
Contributor

@G-Ork G-Ork commented May 5, 2017

Added integration- and unit tests to prove functionality. Extend site to document new attributes in plug-in configuration. I'm using this plug in to generate documentation via docBook xslt. I really need this feature to split the manual in handy pieces.

@khmarbaise
Copy link
Member

Can you please squash your commits....

@G-Ork
Copy link
Contributor Author

G-Ork commented May 6, 2017

Can you give me a hint? The Github docs pointing out there is a button to squash my commits. I don't see it

@khmarbaise
Copy link
Member

khmarbaise commented May 6, 2017

A hint for example: https://egghead.io/lessons/javascript-how-to-squash-multiple-git-commits
Don't forget to make a issue first and add the information into the commit message like

Fixed #XX
 o Some more details here

Added support for xinclude in transformation and validation

Added integration- and unit tests to prove functionality.
Extend site to document new attributes in plug-in configuration.
@G-Ork
Copy link
Contributor Author

G-Ork commented May 6, 2017

Thank you. I've change it.

@khmarbaise khmarbaise merged commit 938f3c5 into mojohaus:master May 7, 2017
@G-Ork
Copy link
Contributor Author

G-Ork commented May 23, 2017

Do you plan to release the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants