Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert support for phoenix 1.6 from the master branch #287

Merged
merged 2 commits into from
Jan 29, 2022

Conversation

chewnoill
Copy link
Contributor

@chewnoill chewnoill commented Jan 27, 2022

  • Reverts support for phoenix 1.6
    Torch won't support phoenix 1.6 officially until 4.0

@chewnoill chewnoill changed the title legacy branch [chore] split support to legacy branch Jan 27, 2022
@cpjolicoeur
Copy link
Member

@chewnoill see my note here regarding Torch 3/4 and branching: #286 (comment)

@chewnoill chewnoill changed the title [chore] split support to legacy branch Revert support for phoenix 1.6 from the master branch Jan 27, 2022
Copy link
Member

@cpjolicoeur cpjolicoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chewnoill as part of this PR can we update the README to include copy/notes that Torch 3/mainline only supports Phx 1.5 and below, and then also point people to the v4 branch for Phx 1.6+ support.

@chewnoill chewnoill force-pushed the wc/legacy-branch branch 2 times, most recently from 85acf5f to 4df7aa7 Compare January 28, 2022 19:13
@chewnoill
Copy link
Contributor Author

elixir 1.10 builds are failing now, Not sure what changed here:

Generating docs...
** (ExDoc.Retriever.Error) module Mix.Tasks.Torch.Gen.Html is not defined/available
(ex_doc 0.28.0) lib/ex_doc/retriever.ex:89: ExDoc.Retriever.docs_chunk/1
(ex_doc 0.28.0) lib/ex_doc/retriever.ex:55: ExDoc.Retriever.get_module/2
(elixir 1.10.4) lib/enum.ex:3343: Enum.flat_map_list/2
(ex_doc 0.28.0) lib/ex_doc/retriever.ex:42: ExDoc.Retriever.docs_from_modules/2
(ex_doc 0.28.0) lib/ex_doc.ex:24: ExDoc.generate_docs/3
(ex_doc 0.28.0) lib/mix/tasks/docs.ex:359: anonymous fn/7 in Mix.Tasks.Docs.run/3
(elixir 1.10.4) lib/enum.ex:2111: Enum."-reduce/3-lists^foldl/2-0-"/3
(ex_doc 0.28.0) lib/mix/tasks/docs.ex:358: Mix.Tasks.Docs.run/3

@cpjolicoeur
Copy link
Member

elixir 1.10 builds are failing now, Not sure what changed here:

Generating docs...
** (ExDoc.Retriever.Error) module Mix.Tasks.Torch.Gen.Html is not defined/available
(ex_doc 0.28.0) lib/ex_doc/retriever.ex:89: ExDoc.Retriever.docs_chunk/1
(ex_doc 0.28.0) lib/ex_doc/retriever.ex:55: ExDoc.Retriever.get_module/2
(elixir 1.10.4) lib/enum.ex:3343: Enum.flat_map_list/2
(ex_doc 0.28.0) lib/ex_doc/retriever.ex:42: ExDoc.Retriever.docs_from_modules/2
(ex_doc 0.28.0) lib/ex_doc.ex:24: ExDoc.generate_docs/3
(ex_doc 0.28.0) lib/mix/tasks/docs.ex:359: anonymous fn/7 in Mix.Tasks.Docs.run/3
(elixir 1.10.4) lib/enum.ex:2111: Enum."-reduce/3-lists^foldl/2-0-"/3
(ex_doc 0.28.0) lib/mix/tasks/docs.ex:358: Mix.Tasks.Docs.run/3

I merged this earlier: #285

I didn't notice in the changelog that it ways 0.28.0 requires Elixir 1.10+.

I'll revert that PR and then you can rebase.

README.md Outdated
@@ -5,6 +5,10 @@

# Torch

> This version of torch (3.x) only supports phoenix 1.5 and below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos here. "Torch" and "Phoenix"

@cpjolicoeur
Copy link
Member

ok @chewnoill #288 merged. you can rebase this now

@cpjolicoeur cpjolicoeur merged commit d57a3b1 into master Jan 29, 2022
@cpjolicoeur cpjolicoeur deleted the wc/legacy-branch branch January 29, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants