Fix part of lint/go errors (deadcode, ineffassign, depguard) (pipe-cd…

…#4624) * Ignore mannwhitney from golangci-lint Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (deadcode) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>
moko-poi · Nov 3, 2023 · a636eea · a636eea
1 parent 39bef2c
commit a636eea
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -4,6 +4,7 @@ run:
     - ^.*\.(pb|y)\.go$
   skip-dirs:
     - "vendor$"
+    - "pkg/app/piped/executor/analysis/mannwhitney"
 
 linters:
   disable-all: true

diff --git a/pkg/app/ops/planpreviewoutputcleaner/cleaner.go b/pkg/app/ops/planpreviewoutputcleaner/cleaner.go
@@ -28,7 +28,6 @@ import (
 const (
 	outputTTL    = 48 * time.Hour
 	cronSchedule = "0 9 * * *" // Run at 09:00 every day.
-	interval     = 24 * time.Hour
 	prefix       = "command-output/"
 )
 

diff --git a/pkg/app/piped/livestatestore/cloudrun/store.go b/pkg/app/piped/livestatestore/cloudrun/store.go
@@ -17,9 +17,9 @@ package cloudrun
 import (
 	"context"
 	"fmt"
-	"sync/atomic"
 	"time"
 
+	"go.uber.org/atomic"
 	"go.uber.org/zap"
 
 	provider "github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/cloudrun"

diff --git a/pkg/app/server/grpcapi/grpcapi.go b/pkg/app/server/grpcapi/grpcapi.go
@@ -184,10 +184,6 @@ func gRPCStoreError(err error, msg string) error {
 	return status.Error(codes.Internal, fmt.Sprintf("Failed to %s", msg))
 }
 
-func makeUnregisteredAppsCacheKey(projectID string) string {
-	return fmt.Sprintf("HASHKEY:UNREGISTERED_APPS:%s", projectID)
-}
-
 func getPipedStatus(cs cache.Cache, id string) (model.Piped_ConnectionStatus, error) {
 	pipedStatus, err := cs.Get(id)
 	if errors.Is(err, cache.ErrNotFound) {