Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The current types for the
LoggerFactory
andBase
Logger are incorrect in some cases or not specific enough in others. Multiple methods are acceptingGenericObject
instead of the more accurateLoggerBindings
type and have been updated accordingly. Additionally, rather than allowingstring
as a type for the log levels return value, the more specificLogLevels
type was used. Finally, the return types forgetLogHandler
was updated to reflect the correct return type of the function.💎 Type of change
🚦 How Has This Been Tested?
I've patched my local moleculer installation with these changes and implemented a custom logger using those fixed types.
🏁 Checklist: