Remove unnecessary clone in node update method #1274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We have a lot of instances of the app, with a bunch of services.
When app starts it took too long(4 sec on average) of active node cpu workload.
I've used the node debug to find a hot spot.
That was a deepClone in update method of node.js.
It might be not necessary to clone the object because it comes from transport and it isn't used after.
I think current tests it has to be enough to prove that everything ok with the registry
💎 Type of change
🚦 How Has This Been Tested?
It has to be enough current tests of node-catalog
🏁 Checklist: