Improve broker error handler types #1286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The
errorHandler
option that can be supplied to the service broker options has loose type definitions for theinfo
parameter. In one case it is defined asany
, and in the other it is defined asGenericObject
(i.e.Record<string,any>
). The signature of the callers to theerrorHandler
is variable, but it falls into two distinct categories: when called from the error handler middleware and when called from other broker workflows. These results in two possible types for theinfo
parameter.This PR updates the type definitions to be more specific about the types for the
info
parameter for the broker'serrorHandler
option.🎯 Relevant issues
None
💎 Type of change
🚦 How Has This Been Tested?
I patched these changes into my repository and then created a new error handler function which used the
info
parameter.🏁 Checklist: