fix: updated removePendingRequestByNodeID #1306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added clean and close this.pendingReqStreams when node disconnected
📝 Description
Fixed memory leak when another microservice started stream with broker.call and then switched off (with reboot for example)
Create two services, a caller and a listener
Listener implements an action stream
Caller calls the listener action stream
Make Caller fail (restart microservice) and Listener memory/stream (in src/transit.js -> this.pendingReqStreams) is not released.
Caller calls again
Caller fails again
After several retries listener may throws a out of memory exception.
PS
this.pendingRequests was empty on Listener microservice
💎 Type of change
🏁 Checklist:
Repo for reproduce this bug
https://github.com/JS-AK/moleculer-pr-1306-example