Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stopDelay to BrokerRegistryOptions Typescript type #1310

Merged

Conversation

kthompson23
Copy link
Contributor

📝 Description

This change adds stopDelay to the BrokerRegistryOptions Typescript type as an optional number. This allows Typescript users to override the stopDelay property on the broker to give other services more time to update their internal registries during a node shutdown.

🎯 Relevant issues

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

📜 Example code

const broker = new ServiceBroker({
	logger: true,
	registry: {
		stopDelay: 1000
	}
});

🚦 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I built a Typescript service/broker with the stopDelay property set in the registry options. The project compiled without error.

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

npm i https://pkg.pr.new/moleculerjs/moleculer@1310

commit: 50c4590

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@icebob icebob merged commit 4014a8c into moleculerjs:master Nov 15, 2024
179 checks passed
@kthompson23 kthompson23 deleted the add-broker-registry-type-stop-delay branch November 15, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants