Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR catalogue is broken due to a query involving Networks.partOfNetworks refback which breaks the data model <= cannot reproduce? #4086

Closed
BrendaHijmans opened this issue Jul 29, 2024 · 4 comments · May be fixed by #4088
Closed

SSR catalogue is broken due to a query involving Networks.partOfNetworks refback which breaks the data model <= cannot reproduce? #4086

BrendaHijmans opened this issue Jul 29, 2024 · 4 comments · May be fixed by #4088
Assignees
@BrendaHijmans
Labels
bug Something isn't working priority Features/bugs that we should not let wait

Comments

@BrendaHijmans
Copy link
Contributor

What version of EMX2 are you using (see footer)
10.106.2

Describe the bug
The SSR interface is broken since this merge: #4048, when a query was implemented using a data model change that makes a circular reference.
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://emx2.dev.molgenis.org/catalogue-demo/ssr-catalogue/
  2. Click on any catalogue
  3. Get a blue screen, without any call to action buttons

Expected behavior
A clear and concise description of what you expected to happen.Expect to see call to action buttons

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@BrendaHijmans BrendaHijmans added bug Something isn't working priority Features/bugs that we should not let wait labels Jul 29, 2024
@mswertz
Copy link
Member

mswertz commented Jul 30, 2024 •
edited
Loading

As part of the migration you should create the 'partOfNetworks' refback field.]

I would expect we can upload the latest data model but that doesn't work, you get
image

I made a fix to remove that error

@mswertz
Copy link
Member

mswertz commented Jul 30, 2024

@BrendaHijmans please help me: were are migrations for data catalogue documented?

@mswertz mswertz mentioned this issue Jul 30, 2024
Draft
4 tasks
@mswertz
Copy link
Member

mswertz commented Jul 30, 2024 •
edited
Loading

I was actually able to upload a edited download of demo catalogue schema where I added the partOfNetworks conform latest in master

molgenis.csv

(need to sign out and in to reload)

@mswertz
Copy link
Member

mswertz commented Oct 8, 2024

I cannot reproduce

@mswertz mswertz changed the title SSR catalogue is broken due to a query involving Networks.partOfNetworks refback which breaks the data model (circular reference) SSR catalogue is broken due to a query involving Networks.partOfNetworks refback which breaks the data model <= cannot reproduce? Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrendaHijmans BrendaHijmans

Labels
bug Something isn't working priority Features/bugs that we should not let wait
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(upload): remove eager circular errors when superclass points to subclass molgenis/molgenis-emx2
2 participants
@mswertz @BrendaHijmans