Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): remove eager circular errors when superclass points to subclass #4088

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Jul 30, 2024

closes #4086

What are the main changes you did:

  • remove circular check (it is actually too eager)
  • check that it works for RD3 (actually I merged this already into that PR)

how to test:

todo:

  • make sure migration function create first tables with primary keys, and then all other columns otherwise we will have errors when creating tables unsorted with missing foreign keys

@mswertz mswertz marked this pull request as draft July 30, 2024 07:42
@mswertz mswertz changed the title fix: eager circular errors when superclass points to subclass fix(upload): remove eager circular errors when superclass points to subclass Jul 30, 2024
@mswertz mswertz marked this pull request as ready for review July 30, 2024 16:10
Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

sonarcloud bot commented Oct 8, 2024

@mswertz mswertz marked this pull request as draft October 14, 2024 21:48
@mswertz mswertz self-assigned this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant