-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In variable detail view, 'harmonisation status per data source' should be changed to 'harmonisation status per source' #4386
Comments
It has changed in the menu on the left-hand side and for harmonisation status on the right-hand side, but it still says 'harmonisation details per data source' here: https://emx2.dev.molgenis.org/catalogue/ssr-catalogue/testNetwork1/variables/testVarRepeats_-testNetwork1-cdm_1-testNetwork1?keys={%22name%22:%22testVarRepeats_%22,%22resource%22:{%22id%22:%22testNetwork1%22},%22dataset%22:{%22name%22:%22cdm_1%22,%22resource%22:{%22id%22:%22testNetwork1%22}}} |
Why close this again? It doesn't seem to be fixed. |
There are two places where 'harmonisation...per data source' appears, in both the menu LHS and the tiles RHS: harmonisation status per source The menu LHS has been corrected for both, but only the first tile has been corrected. The second tile ('harmonisation details per data source') needs to be corrected. And then we're done! |
What version of EMX2 are you using (see footer)
v11.22.0
Describe the bug
For consistency, in the variable detail view, 'harmonisation status per data source' should be changed to 'harmonisation status per source'. In the harmonisation matrix and variable overview, we also speak of 'sources' for cohorts, data sources etc.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The label 'harmonisation status per data source' in the variable detail view, should be changed to 'harmonisation status per source'
The text was updated successfully, but these errors were encountered: