Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In variable detail view, 'harmonisation status per data source' should be changed to 'harmonisation status per source' #4386

Open
BrendaHijmans opened this issue Oct 23, 2024 · 3 comments · May be fixed by #4500
Assignees
Labels
invalid This doesn't seem right

Comments

@BrendaHijmans
Copy link
Contributor

BrendaHijmans commented Oct 23, 2024

What version of EMX2 are you using (see footer)
v11.22.0

Describe the bug
For consistency, in the variable detail view, 'harmonisation status per data source' should be changed to 'harmonisation status per source'. In the harmonisation matrix and variable overview, we also speak of 'sources' for cohorts, data sources etc.

To Reproduce
Steps to reproduce the behavior:

  1. Go to e.g. https://data-catalogue-acc.molgeniscloud.org/catalogue/ssr-catalogue/EHEN/variables/prepreg_cig-LifeCycle-core-LifeCycle?keys={%22name%22:%22prepreg_cig%22,%22resource%22:{%22id%22:%22LifeCycle%22},%22dataset%22:{%22name%22:%22core%22,%22resource%22:{%22id%22:%22LifeCycle%22}}}
  2. See the difference with e.g. https://data-catalogue-acc.molgeniscloud.org/catalogue/ssr-catalogue/EHEN/variables

Expected behavior
The label 'harmonisation status per data source' in the variable detail view, should be changed to 'harmonisation status per source'

@BrendaHijmans BrendaHijmans added the invalid This doesn't seem right label Oct 23, 2024
connoratrug added a commit that referenced this issue Nov 11, 2024
@connoratrug connoratrug linked a pull request Nov 11, 2024 that will close this issue
3 tasks
@connoratrug connoratrug self-assigned this Nov 11, 2024
@hslh
Copy link
Contributor

hslh commented Nov 11, 2024

@hslh hslh reopened this Nov 11, 2024
@hslh
Copy link
Contributor

hslh commented Nov 13, 2024

Why close this again? It doesn't seem to be fixed.

@hslh hslh reopened this Nov 13, 2024
@EleanorHyde-UMCG
Copy link
Contributor

There are two places where 'harmonisation...per data source' appears, in both the menu LHS and the tiles RHS:

harmonisation status per source
harmonisation details per source

The menu LHS has been corrected for both, but only the first tile has been corrected. The second tile ('harmonisation details per data source') needs to be corrected. And then we're done!

See this example in acc:
https://data-catalogue-acc.molgeniscloud.org/testCatalogue/ssr-catalogue/testNetwork1/variables/testVarRepeats_-testNetwork1-cdm_1-testNetwork1?keys={%22name%22:%22testVarRepeats_%22,%22resource%22:{%22id%22:%22testNetwork1%22},%22dataset%22:{%22name%22:%22cdm_1%22,%22resource%22:{%22id%22:%22testNetwork1%22}}}

And in dev:
https://emx2.dev.molgenis.org/catalogue-demo/ssr-catalogue/testNetwork1/variables/testVarRepeats_-testNetwork1-cdm_1-testNetwork1?keys={%22name%22:%22testVarRepeats_%22,%22resource%22:{%22id%22:%22testNetwork1%22},%22dataset%22:{%22name%22:%22cdm_1%22,%22resource%22:{%22id%22:%22testNetwork1%22}}}

@connoratrug connoratrug removed their assignment Nov 14, 2024
@connoratrug connoratrug removed a link to a pull request Nov 15, 2024
3 tasks
@connoratrug connoratrug linked a pull request Nov 15, 2024 that will close this issue
@connoratrug connoratrug self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants