fix(settings): Have a better email input in member settings #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
mswertz
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email input in member settings nows has a email check and will also validate 'user' and 'anonymous'
Added a information icon
Fixed information icon to make sure it can display larger text and that the 'hidden' state would blok buttons below it.
Fixed InputEmail. It was broken, the TS typing is not implemented completely at the vue side of things. No good workaround so we are back using vue typing for the props.
See: How to import interface for defineProps vuejs/core#4294 and Error: [@vue/compiler-sfc] Failed to resolve index type into finite keys vuejs/core#8286 "If understand correctly this issue (which I also ran into) basically means that Vue 3 only supports "trivial" TypeScript types for props." - gorankarlic