Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(central): remove and enable/disable users via admin ui #4167

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

MaxPostema
Copy link
Contributor

@MaxPostema MaxPostema commented Aug 28, 2024

fixes: #3981

What are the main changes you did:

  • remove user button
  • enable and disable user accounts toggle

how to test:

  • Go to: apps/central/#/admin/users
  • create a user / remove users
  • try to disable an user and login

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Todo:

  • combine removeUser and deleteUser?
  • backend and frontend should not be able to disable "anonymous and admin"
  • test coverage

@MaxPostema MaxPostema changed the title feat: remove, add disable users ui feat(central): remove and enable/disable users via admin ui Aug 29, 2024
@MaxPostema MaxPostema marked this pull request as ready for review September 10, 2024 12:57
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a functional test:

  • I like the option to disable a user, when checking the user list it however seems a bit as if all users are disabled and the disabled ones are valid (looking at the sign of the person
    image, but when hoovering over it is already clearly indicated => and also the values in the enabled column are clear enough.
  • Deleting a user works fine, however, when it's in a member list in a schema it does not get removed there => which makes me wonder if it's really removed from the backend as I would think that the "userlist" in admin would be the main source?

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.
should not be able to disable anonymous
should have more test coverage?

Copy link

sonarcloud bot commented Sep 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(user management): As data manager I want to be able to delete users using the UI
3 participants