-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(central): remove and enable/disable users via admin ui #4167
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a functional test:
- I like the option to disable a user, when checking the user list it however seems a bit as if all users are disabled and the disabled ones are valid (looking at the sign of the person
, but when hoovering over it is already clearly indicated => and also the values in the enabled column are clear enough. - Deleting a user works fine, however, when it's in a member list in a schema it does not get removed there => which makes me wonder if it's really removed from the backend as I would think that the "userlist" in admin would be the main source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
should not be able to disable anonymous
should have more test coverage?
Quality Gate passedIssues Measures |
fixes: #3981
What are the main changes you did:
how to test:
todo:
Todo: