Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (tailwind): init radio and radio group components #4231

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Sep 18, 2024

What are the main changes you did:

  • Added base component for radio input
  • Added component for creating a group of radio inputs
  • Added e2e test and revised e2e docs

how to test:

todo:

  • updated docs in case of new feature (see showcase app)
  • Add e2e test
  • add button that clears selected values

@davidruvolo51 davidruvolo51 marked this pull request as ready for review September 26, 2024 12:30
@connoratrug
Copy link
Contributor

connoratrug commented Sep 26, 2024

The alignment seems to be of ( text not vertically centered with the circle), like in the design
Screenshot 2024-09-26 at 14 40 24

also see ( we dont have the figma files yet)
Screenshot 2024-09-26 at 15 21 09

v-model="modelValue"
:value="value"
type="radio"
class="w-5 h-5 ml-[6px] mr-2.5 mt-0.5 accent-yellow-500 hover:cursor-pointer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the style looks a little bit different then the design
Screenshot 2024-09-26 at 14 47 42

</ul>
<h3>Input radio group examples</h3>
<form class="mt-4 [&_fieldset]:mb-4">
<fieldset class="flex flex-col gap-1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a case where the value is already set ( tests the initial value is correctly set)

Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General input functionality works, think we need to change to double synced arrays ( see comment for details )

Would suggest adding it the the FormField so we can test the form interaction

few small design tweaks needed to match design ( maybe have a look a the ontology filter classes )

Copy link

sonarcloud bot commented Sep 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants