Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs and templates update #4243

Merged
merged 36 commits into from
Nov 7, 2024
Merged

Conversation

BrendaHijmans
Copy link
Contributor

@BrendaHijmans BrendaHijmans commented Sep 20, 2024

closes #https://github.com/molgenis/GCC/issues/430

NOTE: links to images and xlsx will not work, because they point to master code. See the files changed for the updated templates and images

What are the main changes you did:

  • docs and templates for metadata upload changed

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@BrendaHijmans BrendaHijmans changed the title chore: docs to 4.0 chore: docs and templates to 4.0 Sep 20, 2024
@BrendaHijmans BrendaHijmans changed the title chore: docs and templates to 4.0 chore: docs and templates update Oct 7, 2024
@BrendaHijmans BrendaHijmans marked this pull request as ready for review October 7, 2024 13:08
Copy link
Contributor

@timcadman timcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a few suggestions on the English but otherwise looks good :)

docs/catalogue/cat_network-data-manager.md Outdated Show resolved Hide resolved
docs/catalogue/cat_network-data-manager.md Outdated Show resolved Hide resolved
docs/catalogue/cat_network-data-manager.md Outdated Show resolved Hide resolved
docs/catalogue/cat_network-data-manager.md Outdated Show resolved Hide resolved
docs/catalogue/cat_network-data-manager.md Outdated Show resolved Hide resolved
Copy link
Contributor

@timcadman timcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more 'the' that needs to be added but happy to approve it

docs/catalogue/cat_network-data-manager.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 23, 2024

@BrendaHijmans BrendaHijmans merged commit cdde4e1 into master Nov 7, 2024
6 checks passed
@BrendaHijmans BrendaHijmans deleted the chore/update-templates branch November 7, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants