-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin): add user role management #4248
Draft
chinook25
wants to merge
83
commits into
master
Choose a base branch
from
feat/admin-role-management
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
63b758d
feat(admin): add user role management
chinook25 092408a
wip: admin page tries request
chinook25 4509030
wip: use useFetch (not working)
chinook25 4a69b28
wip: now it retrieves!
chinook25 a4b5171
wip: retrieve tokens
chinook25 7612f38
wip: add murmurs
chinook25 faf3f5b
Merge branch 'master' into feat/admin-role-management
chinook25 20477dc
wip: use useFetch
chinook25 239fe1e
wip: pagination working
chinook25 3981a51
wip: limit 20
chinook25 bebe5dc
wip: correct next page
chinook25 f11b42d
wip: add roles to user
chinook25 b57ab94
wip: add column to db
chinook25 9090611
wip rename
chinook25 7e678c9
Merge branch 'master' into feat/admin-role-management
chinook25 15c32fb
now with correct query
chinook25 7449963
adding roles to sql
chinook25 c49169a
Merge branch 'master' into feat/admin-role-management
mswertz 1b428a0
Merge branch 'master' into feat/admin-role-management
chinook25 cd45861
Merge branch 'master' into feat/admin-role-management
chinook25 78b2e47
Merge branch 'master' into feat/admin-role-management
chinook25 086705d
wip: trying to retrieve roles, almost there?
chinook25 0bf018a
wip: remove unused code
chinook25 d7b20b5
chore: format
chinook25 de1e694
chore: format
chinook25 f2f245d
feat: retrieving roles works
chinook25 32aabc7
chore: remove roles from user
chinook25 1163a05
chore: remove unused type
chinook25 dddad76
Merge branch 'master' into feat/admin-role-management
chinook25 7bfe0eb
chore: move load roles function
chinook25 f94833b
feat: split result into schema and role
chinook25 3201621
chore: minor refactor
chinook25 7da5b8b
fix: warnings
chinook25 c488c17
chore: nicer role and token display
chinook25 793e626
chore: refactor
chinook25 c059219
feat: add delete and update functions
chinook25 f7d8962
minor chagne
chinook25 6c71ff9
Merge branch 'master' into feat/admin-role-management
chinook25 d73c913
feat: can add users
chinook25 534e7df
Merge branch 'master' into feat/admin-role-management
chinook25 3380177
merge master
chinook25 30279c2
Merge branch 'master' into feat/admin-role-management
chinook25 2cc3874
chore: add comments
chinook25 9dc7425
feat: show enabled; wip: start with edit user modal
chinook25 ae6f00b
Merge branch 'master' into feat/admin-role-management
chinook25 0204c24
feat: put create user in modal
chinook25 27a700a
feat:retrieve roles
chinook25 4434a7d
chore: move functions to util file
chinook25 c6bed32
feat: show tokens in modal
chinook25 a7820f6
feat: add dis-/en-able button
chinook25 55fa5b6
chore: tsing
chinook25 eb03b44
chore: move edit user modal to component
chinook25 1ae772e
feat?: wip edit user
chinook25 bcbb249
feat: interface to add/remove roles and remove tokens
chinook25 a5d7c20
edit password field
chinook25 67946f0
Merge branch 'master' into feat/admin-role-management
chinook25 e216d99
wip: adding update user endpoint
chinook25 1d92672
wip: making update user endpoint
chinook25 b44047d
wip: gql query correct?
chinook25 5641f8c
update pass
chinook25 372a54c
feat: can commit user changes;fix: disabled user toggles correctly
chinook25 6f75747
Merge branch 'master' into feat/admin-role-management
chinook25 6883c43
feat: can now save enabling;update list on save
chinook25 e2e38c0
feat: make role api better
chinook25 c6a71b6
Merge branch 'master' into feat/admin-role-management
chinook25 875b9d0
wip: adding role api
chinook25 e5f61ab
fix: import
chinook25 0f4df76
feat: can add and remove roles!
chinook25 20480e7
feat: can now update existing roles
chinook25 e25daca
chore:refactor
chinook25 5a5d70c
Merge branch 'master' into feat/admin-role-management
chinook25 40286b9
test: add working start of test
chinook25 bca1285
chore: basic test
chinook25 4314bca
test: basic change test
chinook25 31ec18e
test: basic change test
chinook25 bc21da8
chore: test updateUser
chinook25 9e3b520
chore: improve cov
chinook25 d09a101
chore: refactor to make sonarcloud happy
chinook25 60842d5
chore: refactor to make sonarcloud happy
chinook25 f8d2ec1
chore: refactor to make sonarcloud happy
chinook25 6f33ba6
chore: more sonarring
chinook25 b8f192b
chore: remove dead code
chinook25 732cb00
chore: undo remove code
chinook25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should should work, but by keeping the useFetch at the page level and using the 'refresh' or computed there is no need for a separate getUsers func and the setup code . This has the added value of exposing the dat, status, error refs at the page level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds cool, didn't get it to work that way though with the pagination.