Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4246 include key details in mapping fetch #4252

Conversation

connoratrug
Copy link
Contributor

Closes #4246

What are the main changes you did:

  • explain what you changed and essential considerations.

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

connoratrug and others added 4 commits September 25, 2024 15:09
…u-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up
…u-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up
…u-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up
…u-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up
mswertz
mswertz previously approved these changes Sep 30, 2024
@mswertz mswertz dismissed their stale review September 30, 2024 10:59

sorry, too early should test functinally

connoratrug and others added 3 commits September 30, 2024 14:57
…u-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up
…u-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up
…u-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up
Copy link

sonarcloud bot commented Oct 1, 2024

@connoratrug connoratrug merged commit be15fa7 into master Oct 2, 2024
6 checks passed
@connoratrug connoratrug deleted the 4246-fixcatalogue-on-variable-page-when-you-click-a-source-variable-under-harmonisation-details-per-collection-nothing-happens-no-dialog-pops-up branch October 2, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants