fix(catalogue): variable list should show +n when repeat info is set #4259
Conversation
| @@ -14,6 +14,10 @@ const props = withDefaults( | |||
| const variableKey = computed(() => getKey(props.variable)); | |||
|
|
|||
| const resourcePathId = resourceIdPath(variableKey.value); | |||
|
|
|||
| function repeats(variable: IVariable) { | |||
There was a problem hiding this comment.
repeats is the max - min ?? , whats use case is this number supporting
There was a problem hiding this comment.
the number of repeats as before. E.g. when the variable defines are measurements from week 5 - 10 THEN repeats = 5 <= I now see my mistake. Is actually 4?
You might see in popup there is shown as 'week 5 - 10'.
We could replace with this sentence, is just a bit longer but much more useful. What do you think? Otherwise we can consult Brenda or Marije
There was a problem hiding this comment.
the original design had the variable name ( label ,... something for a human to identify the item with). variable names are already a bit meh, then we add the repeats ( caused more render issues , added more css for edge cases) adding even more without changing the card design might not be ideal
There was a problem hiding this comment.
to me the number feels confusing, but i you think most end users will understand the meaning i'm fine with the change
There was a problem hiding this comment.
I do agree with you actually. I was just reinstating previous behavior. I will give at a go to make it more meaningfull
| @@ -14,6 +14,10 @@ const props = withDefaults( | |||
| const variableKey = computed(() => getKey(props.variable)); | |||
|
|
|||
| const resourcePathId = resourceIdPath(variableKey.value); | |||
|
|
|||
| function repeats(variable: IVariable) { | |||
There was a problem hiding this comment.
indeed, my mind was still thinking we are working on a list
|
closes #4259
What are the main changes you did:
how to test:
todo: