Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove demo/template data #4312

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: remove demo/template data #4312

merged 1 commit into from
Oct 7, 2024

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Oct 3, 2024 •
edited
Loading

What are the main changes you did:
Removed hard code template / data

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mswertz
Copy link
Member

mswertz commented Oct 3, 2024

pls change description so I understand, even empty is better ;-)

mswertz
mswertz reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we/they want to keep part of this, see sharepoint notes

@connoratrug
Copy link
Contributor Author

I believe we/they want to keep part of this, see sharepoint notes

?? this is hardcoded example data from the design agency

@connoratrug connoratrug merged commit 4df6e68 into master Oct 7, 2024
6 checks passed
@connoratrug connoratrug deleted the fix/remove-demo-data branch October 7, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz left review comments

@chinook25 chinook25 chinook25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connoratrug @mswertz @chinook25