Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edit overlap resource and cohort types #4355

Merged
merged 5 commits into from
Oct 15, 2024
Merged

fix: edit overlap resource and cohort types #4355

merged 5 commits into from
Oct 15, 2024

Conversation

BrendaHijmans
Copy link
Contributor

@BrendaHijmans BrendaHijmans commented Oct 14, 2024 •
edited
Loading

What are the main changes you did:

  • removed from cohort types:
    Registry
    Clinical trial
    Biobank

-Demo data updated

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@BrendaHijmans BrendaHijmans marked this pull request as ready for review October 14, 2024 14:45
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BrendaHijmans BrendaHijmans merged commit ffa3b22 into master Oct 15, 2024
4 of 5 checks passed
@BrendaHijmans BrendaHijmans deleted the fix/cohort-types branch October 15, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrendaHijmans @mswertz