Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directory): add study table to staging template #4461

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

dtroelofsprins
Copy link
Contributor

What are the main changes you did:

  • Added studies table + studies column in Collections to the molgenis.csv of the biobank_directory staging template
  • Included demo studies data

how to test:

  • Goto the preview, create a new database using biobank_directory_staging template, including demo-data => check that the Studies table is there, including some demo data. Also the Collections table contains now a Studies column linked to the Studies table

todo:

  • [nvt] updated docs in case of new feature
  • added/updated tests
  • [nvt] added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik kan een studie maken met als ID bmri-eric:... dus met maar één B. Er zit geen goede validatie op de IDs.

Copy link

sonarcloud bot commented Nov 8, 2024

Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basis validatie werkt nu ook

@dtroelofsprins dtroelofsprins merged commit b6c58ea into master Nov 8, 2024
6 checks passed
@dtroelofsprins dtroelofsprins deleted the feat/directory-nn-studies branch November 8, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants