Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show paging text when in box ( inverted colors) #4467

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

connoratrug
Copy link
Contributor

Closes #4460

What are the main changes you did:

  • put back inverted option in pagination component
  • put back inverted colors in styles
  • set inverted true if pagination is used in box ( inverted colors)

how to test:

  • see issue

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

- put back inverted option in pagination component
- put back inverted colors in styles
- set inverted true if pagination is used in box ( inverted colors)
Copy link

sonarcloud bot commented Nov 10, 2024

Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is dit enige met pagination?

@connoratrug
Copy link
Contributor Author

connoratrug commented Nov 11, 2024

is dit enige met pagination?

o de enig in box ( met witte achtergrond denk ik ja )

@connoratrug connoratrug merged commit 2ffe0b1 into master Nov 11, 2024
5 of 6 checks passed
@connoratrug connoratrug deleted the fix/4460-paging-text-on-inverted-background branch November 11, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants