feat: catalogue can use google analytics #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to choose analytics provider ( siteimprove or googlegoogle-analytics) Analytics key can still be set via NUXT_PUBLIC_ANALYTICS_KEY env var Provider can be set via NUXT_PUBLIC_ANALYTICS_PROVIDER env var
mswertz
reviewed
Nov 11, 2024
| @@ -109,3 +109,10 @@ The label shown on landing CTA element for each of the main sections | |||
|
|
|||
| A Themed favicon is set by placing a [theme].icon file in the public/img folder. At runtime the [theme] is replaced by the value as set in ```NUXT_PUBLIC_EMX2_THEME``` environment setting. If no theme is set, the default molgenis favicon is show. | |||
|
|
|||
| ## Analytics | |||
|
|
|||
| Analytics can be enabled by setting the following environment variables: | |||
There was a problem hiding this comment.
can I also set this via the user interface?
There was a problem hiding this comment.
i thought about that, but has several implication for ssr render speed ( if it could change at any time , is always needs to checked in the db ) , would suggest to keep as it, evaluatie this setup ( i suspect not not need to change this often ) , also having these kinds of things injected from the environment has the benefit of being able to move the project/db around while having different configs for acc, prod, ...
|
mswertz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
See: https://github.com/orgs/molgenis/projects/15/views/1?sliceBy%5Bvalue%5D=Dev&pane=issue&itemId=79942482&issue=molgenis%7CGCC%7C648
how to test:
todo: